Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
$view = &$form_state['view'];
is not needed in PHP5. When it is an object, it shouldn't have an & for reference, it is redundant.
This should be done right before code freeze. Here's a patch to get started.
Comment | File | Size | Author |
---|---|---|---|
#18 | 1959338-18.patch | 18.15 KB | damiankloip |
#18 | interdiff-1959338-18.txt | 764 bytes | damiankloip |
#16 | php4_style_references-1959338-16.patch | 18.22 KB | superspring |
#14 | php4_style_references-1959338-14.patch | 958 bytes | superspring |
#12 | php4_style_references-1959338-12.patch | 18.27 KB | superspring |
Comments
Comment #1
alexmoreno CreditAttribution: alexmoreno commentedI will work on it as part of the Drupal London sprint may 2013
Comment #2
alexmoreno CreditAttribution: alexmoreno commentedI think it must be something wrong with the last patch, if someone could guide me through where to continue?
Comment #3
alexmoreno CreditAttribution: alexmoreno commentedok, sorry, I found the problem. I've recreated the patch again following this instructions: http://drupalladder.org/lesson/b93deb54-264f-19a4-49eb-db74bc6c2712
Comment #4
alexmoreno CreditAttribution: alexmoreno commentedComment #5
alexmoreno CreditAttribution: alexmoreno commentedHi tim.plunkett,
I have a quick question. I don't understand these changes:
- $options =& $form_state['values']['options'];
+ $options = &$form_state['values']['options'];
I guess it is simply coding standards, isn't it?
Thanks a lot.
Comment #6
alexmoreno CreditAttribution: alexmoreno commentedthere we go, here is the full patch for views and views_ui
Comment #7
alexmoreno CreditAttribution: alexmoreno commentedsorry, I forgot to attach the patch.
Comment #9
alexmoreno CreditAttribution: alexmoreno commented#7: 1959338-reroll-views.patch queued for re-testing.
Comment #11
dawehnerComment #12
superspring CreditAttribution: superspring commentedSo here is my attempt at a re-roll for this patch.
A quick grep shows quite a few other changes that this no longer reflects.
If this passes the tests I'll add some more of them to the patch.
Comment #14
superspring CreditAttribution: superspring commentedAttempt two
Comment #16
superspring CreditAttribution: superspring commentedAttempt three
Comment #18
damiankloip CreditAttribution: damiankloip commentedNice work superspring. I think an old underscored method call crept back in somehow :)
Comment #19
dawehnerEach line looks really fine.
Comment #20
ceardach CreditAttribution: ceardach commentedRemoved "Needs reroll" because latest patch is RTBC
Comment #21
Xano18: 1959338-18.patch queued for re-testing.
Comment #22
webchickYay, less cruft! :)
Committed and pushed to 8.x. Thanks!
Comment #23
alexmoreno CreditAttribution: alexmoreno commentedgreat to know that my name will be in D8 :-)