Drupal\entity_reference\Tests\EntityReferenceAdminTest->testFieldAdminHandler() causes two exceptions and a test fail that are reproduceable on PHP 5.4.4, 5.4.14, and 5.4.16. The problems don't occur on PHP 5.3.10 and 5.3.14. The exceptions are:
- call_user_func_array() expects parameter 1 to be a valid callback, class 'Content' not found
- call_user_func_array() expects parameter 1 to be a valid callback, class 'type' not found
This duplicate issue has some detective work in the OP: #2043099: Entity Reference UI test fails on PHP 5.4.4 (-> HEAD broken)
Comment | File | Size | Author |
---|---|---|---|
#8 | entity-reference-libxml-weirdness-2025451.patch | 892 bytes | Berdir |
#7 | 2025451-7.patch | 892 bytes | amateescu |
#2 | 2025451.patch | 4.61 KB | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedgit bisect
to the rescue! This was broken by #1946404: Convert forms in field_ui.admin.inc to the new form interface.Comment #2
amateescu CreditAttribution: amateescu commentedI spent some quality (not!) hours with this one, digging through a reference and serialization hell, and this patch seems to fix it.
Comment #3
alexpottNeeds a reroll because #2050367: FieldInstanceFormBase is useless has landed... and this seems related to #2004282: Injected dependencies and serialization hell
Comment #4
amateescu CreditAttribution: amateescu commentedIt's definitely related, if not duplicate. Let's wait a bit with this one for now..
Comment #5
yched CreditAttribution: yched commentedFrom @Berdir on #2071969: Serialize interface not reliable:
Comment #6
amateescu CreditAttribution: amateescu commentedThe notices/fails seems to be fixed on https://qa.drupal.org/pifr/test/600303 (5.4.17) and for me locally on 5.4.4...
Comment #7
amateescu CreditAttribution: amateescu commentedActually, @Berdir says that having the xpath a bit more specific works for him locally, so let's just do this small change.
Comment #8
BerdirYes, with the exception of a weird fail on the last assertion that only seems to happen for me with 5.4.9/libxml 2.9.0 and seems to work fine for @amateescu with 5.4.4/libxml 2.7.7.
Somehow that only returns the first match for me, whereas I assume it returns a list of all field labels for others.
It seems the xpath query can be made more specific to only target the field we care about, then it works with both versions.
Comment #9
amateescu CreditAttribution: amateescu commentedBringing back the more explicit title.
Comment #10
amateescu CreditAttribution: amateescu commentedSo we both posted patches thinking that other one could RTBC it :D Since it's his patch originally, I guess I'll have to push the button.
Comment #11
webchickCommitted and pushed to 8.x. Thanks!
Comment #12.0
(not verified) CreditAttribution: commentedAdded info about a duplicate issue.