This may not be so important in the long term since we are removing all of this code, but it's one less thing to have sitting around in menu.inc

There is a hunk in menu_router_build() that replaces the hook_menu path with the one from the route. If we just make them match we don't have to!

This needs #2102125: Big Local Task Conversion to fix the block demo path.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Uploading a couple different approaches to see what breaks and why.

tim.plunkett’s picture

Status: Needs review » Needs work
Issue tags: -MenuSystemRevamp

The last submitted patch, menu-2107039-2.patch, failed testing.

tim.plunkett’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
25.05 KB
24.82 KB

Theme callback went in.

Status: Needs review » Needs work

The last submitted patch, 4: menu-2107039-4-complete.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
25.77 KB

MENU_DEFAULT_LOCAL_TASKS mean we still need some of this.

Status: Needs review » Needs work

The last submitted patch, 6: menu-2107039-6.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +MenuSystemRevamp
FileSize
39.84 KB

This should fix it. And removes a lot of code in the meantime.

tim.plunkett’s picture

FileSize
39.83 KB

Ugh, bad copy/paste

Status: Needs review » Needs work

The last submitted patch, 8: menu-2107039-8.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

9: menu-2107039-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: menu-2107039-9.patch, failed testing.

tim.plunkett’s picture

dawehner’s picture

This basically touches a lot of similar lines to https://drupal.org/node/2047633 .

tim.plunkett’s picture

Yeah I'll just leave this postponed until all of that is done. This is not urgent, just cleanup.

amateescu’s picture

Status: Postponed » Closed (duplicate)

I think #2177041: Remove all implementations of hook_menu makes this issue obsolete.