Project Page: https://drupal.org/sandbox/michaelhodgejr/2113571
Git Repository: git clone http://git.drupal.org/sandbox/michaelhodgejr/2113571.git tweet_embed
Description
This module creates an input filter that will transform links such as https://twitter.com/lightsky_design/status/393350560902295553 into an Embedded Tweet. It was created as a way to make it easy for content editors to easily embed tweets within their site.
Reviews of other applications
[D7] Get Total - https://drupal.org/node/2122451#comment-8009271
[D7] Menu CSS - https://drupal.org/node/2122649#comment-8009325
[D7] mailredirec7 - https://drupal.org/node/2121197#comment-8009371
Comments
Comment #1
klausiI guess this needs review? See our workflow: https://drupal.org/node/532400
Comment #2
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commented@klausi - Yes, my apologies. I forgot to change the status when submitting.
Comment #4
AjitSThank you for your contribution. Looks like a good functionality to have. Here are my findings:
AUTOMATED REVIEW:
pareview reports some issues http://pareview.sh/pareview/httpgitdrupalorgsandboxmichaelhodgejr2113571git, please clear those up.
MANUAL REVIEW:
Twitter Input Filter module is similar but is only for D6. It shows the Maintenance status and Development Status as unknown. Maybe you could also put in a request to maintain that in D6 (if you have experience working with it).
Maybe you could add
hook_help()
and some more inline comments which could get you past the current benchmark.However, this is a nice functionality and doesn't seem to be present with any other project; so I would vote this to be an promoted to full project.
Comment #5
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedThanks for your feedback. I will go through and fix the issues with the report. I will also add a module settings form. This will allow the user to specify the defaults as well as help bring me over the minimum code requirement.
Comment #6
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedI've fixed the automated errors.
I also went in and adding a module settings page to control the default parameter settings. This not only makes it easier for the user, but also puts me in well over the minimum code requirement.
Please review and let me know your thoughts.
Thanks!
-Mike
Comment #6.0
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedupdated git repo url
Comment #6.1
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedadded review bonus section
Comment #6.2
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedadded second review bonus
Comment #6.3
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedadded third review bonus
Comment #7
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedI've added a README.txt file to the application.
Comment #8
Michael Hodge Jr CreditAttribution: Michael Hodge Jr commentedAdded review bonus tag
Comment #9
mpruitt CreditAttribution: mpruitt commentedAUTOMATED REVIEW:
pareview reports no issues
MANUAL REVIEW:
I have one suggestion, but it in no way affects the operation of the module.
On your admin/config/services/tweet_embed page, it might be helpful to provide an example under each default of how to manually override the default setting. A link to the available options for each setting might be good as well.
Overall, a nice module. I'll remember this the next time I need to embed Tweets.
Comment #10
klausiThis sounds like a feature that should live in the existing twitter project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the twitter issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
There is already an issue to create an input filter: #1365452: Embedded Tweets input filter
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #10.0
klausichanged section title
Comment #11
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.