Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

locale.config.it.tour.tour.tour-test.yml
tour.tour.tour-test-2.yml
tour.tour.tour-test.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#6 2106005-tour-config-cleanup-6.patch3.01 KBvijaycs85
#5 2106005-4-yaml-variable-type.patch1.65 KBnonsie
#3 2106005-3-yaml-variable-type.patch2.48 KBnonsie
#1 2106005-1-yaml-variable-type.patch2.49 KBalexander_danilenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexander_danilenko’s picture

alexander_danilenko CreditAttribution: alexander_danilenko commented
Assigned: Unassigned » alexander_danilenko
Status: Active » Needs review
FileSize
2106005-1-yaml-variable-type.patch2.49 KB

Status: Needs review » Needs work

The last submitted patch, 2106005-1-yaml-variable-type.patch, failed testing.

nonsie’s picture

nonsie
she/her
Primary language Estonian
CreditAttribution: nonsie commented
Status: Needs work » Needs review
FileSize
2106005-3-yaml-variable-type.patch2.48 KB

Boolean true should be lowercase

The last submitted patch, 2106005-3-yaml-variable-type.patch, failed testing.

nonsie’s picture

nonsie
she/her
Primary language Estonian
CreditAttribution: nonsie commented
Assigned: alexander_danilenko » nonsie
Issue summary: View changes
Status: Needs work » Needs review
FileSize
2106005-4-yaml-variable-type.patch1.65 KB

Looks like the patch failed because _access is still true as string not true as boolean

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Make sure all YML files in Tour module has no type-casting to string. » Make sure all YML files in Tour module has no type-casting to string + update stings with quotes
Issue summary: View changes
FileSize
2106005-tour-config-cleanup-6.patch3.01 KB

Fix the label and body text as well...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.