Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Task to convert ValidNumberStepUnitTest to phpunit.
Comment | File | Size | Author |
---|---|---|---|
#20 | interdiff.txt | 884 bytes | jhedstrom |
#20 | system-validnumber-phpunit-2030173-20.patch | 12.17 KB | jhedstrom |
#18 | system-validnumber-phpunit-2030173-18.patch | 12.17 KB | jhedstrom |
#16 | interdiff.txt | 751 bytes | jhedstrom |
#16 | system-validnumber-phpunit-2030173-16.patch | 12.17 KB | jhedstrom |
Comments
Comment #1
jhedstromThis converts
valid_number_step()
to a component (Number::validStep()
), and moves the unit test to phpunit, with dataproviders.Comment #3
jhedstrom#1: system-validnumber-phpunit-2030173-01.patch queued for re-testing.
Comment #5
jhedstromForgot to add the new Number component file.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedwoo, looks good thanks:)
Comment #7
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #8
YesCT CreditAttribution: YesCT commentedThis increases phpunit test code coverage from
Comment #9
catch#5: system-validnumber-phpunit-2030173-05.patch queued for re-testing.
Comment #11
jhedstromRe-rolled #5.
Comment #12
dawehnerThat is a really nice test!
Some lines exceed the 80 chars, so lets fix them.
Lets add an empty line here.
Comment #13
jhedstromShould address #12.
Comment #14
dawehnerThank you
Comment #15
alexpottI'm not sure that we should be removing the documentation of the parameters and return value here... we can remove the the details and replace with the @see...
So I think this should look like this...
... I know I committed a patch by @jhedstrom that removed docs like this is the past but I now consider that a mistake...
Comment #16
jhedstromThis adds those params back. The reason I'd been removing them was due to some really large docblocks (not including the params/return), that seemed silly to duplicate on both the deprecated function and the new component method.
Comment #17
ParisLiakos CreditAttribution: ParisLiakos commentedoh everyone forgot this issue i guess:P
Comment #18
jhedstromRe-roll of #16.
Comment #19
ParisLiakos CreditAttribution: ParisLiakos commented$expected should be the first argument
Comment #20
jhedstromFlipped the argument order as per #19.
Comment #21
ParisLiakos CreditAttribution: ParisLiakos commentedty
Comment #22
catchCommitted/pushed to 8.x, thanks!
Comment #24
jhedstrom