\Drupal\Core\Form\FormInterface::getFormID() does not comply with the coding standards, as we do not use uppercase acronyms in camelcased names. The method should be named getFormId() instead.

CommentFileSizeAuthor
#2 drupal_2111209_2.patch65.15 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Some forms already use getFormId() rather than getFormID(), such as \Drupal\taxonomy\Form\OverviewTerms.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
drupal_2111209_2.patch65.15 KB
amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

Yup.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Assigned: Unassigned » jhodgdon
Status: Reviewed & tested by the community » Fixed

Committed b201c05 and pushed to 8.x. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned

Not sure why you assigned this to me? Our OO naming standards already say to do this for acronyms:
https://drupal.org/node/608152#naming

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

See you in #2113243: Rename BaseFormIdInterface::getBaseFormID() to BaseFormIdInterface::getBaseFormId()!

Automatically closed -- issue fixed for 2 weeks with no activity.