Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
With the style set to "text" and "image and text", the service links are properly contained in an unordered list.
<div class="service-links">
<div class="item-list">
<ul>
<li class="first">
<a class="service-links-reddit" rel="nofollow" title="Submit this post on reddit.com" href="http://reddit.com/submit?url=http%3A//www1/test&title=Test">Reddit</a>
</li>
...
</ul>
</div>
</div>
With the style set to "image", the links are loose in a DIV.
<div class="service-links">
<a class="service-links-reddit" rel="nofollow" title="Submit this post on reddit.com" href="http://reddit.com/submit?url=http%3A//www1/test&title=Test">
<img alt="Reddit logo" src="http://www1/sites/www1/modules/service_links/images/reddit.png" typeof="foaf:Image">
</a>
...
</div>
When using the "non-block" method, configuring the module to use the "only images" style does properly use an unordered list.
Comment | File | Size | Author |
---|---|---|---|
#1 | service_links-2072891-1-theme_item_list_block_images.patch | 611 bytes | Simon Georges |
Comments
Comment #1
Simon Georges CreditAttribution: Simon Georges commentedWould you prefer something like that?
Comment #2
kpaxman CreditAttribution: kpaxman commentedThat definitely fixes the issue I described.
Now that I've got something to compare to, I'm wondering why the source is different between service link blocks and "standard" service links placed with the config page. The "block" version has an extra DIV with the class "item-list", and its UL doesn't have the "links" class. In addition, the "standard" version places the service's class name on both the LI and the A, but the "block" version only places it on the A.
From the "block" version:
From the "standard" version:
Comment #3
Simon Georges CreditAttribution: Simon Georges commentedHaving a quick look yesterday into the theming side of the module, I'm fairly sure it needs some love, unfortunately, neither do I have the time nor do I know the history or reasons why it's like that, so I'm not sure it's my role to do that.
Thanks for your bug report, if you find other related things, that would probably help me tackle whatever needs to be done to have a uniform theming everywhere.
Comment #4
Simon Georges CreditAttribution: Simon Georges commentedComment #5
dddbbb CreditAttribution: dddbbb commentedI'm also pretty keen to see this get fixed. Thanks for the patch.
Comment #6
Simon Georges CreditAttribution: Simon Georges commentedCross-referencing #2064899: Missing li styles in blocks.
Comment #7
dddbbb CreditAttribution: dddbbb commented