Context support for translatables

Hi!

I have the same problem too and I created this patch to fix it. It adds context in the t() function when label and description of field are exported.

Little misstake about context name of a field.
Here the new patch

+++ b/html/sites/all/modules/features/features.export.inc
@@ -512,13 +512,16 @@ function features_var_export($var, $prefix = '', $init = TRUE) {
-  $translatables = array_filter(array_unique($translatables));

What's the reason for removing the array_unique?

+++ b/html/sites/all/modules/features/features.export.inc
@@ -512,13 +512,16 @@ function features_var_export($var, $prefix = '', $init = TRUE) {
+    	if(is_array($string)){
+    		$output .= "{$indent}t(" . features_var_export($string["value"]) . ",array(),array('context' => '".$string["context"]."'));\n";
+    	}else{
+    		$output .= "{$indent}t(" . features_var_export($string) . ");\n";
+    	}      ¶

Tab characters? Coding standards in general.

+++ b/html/sites/all/modules/features/includes/features.field.inc
@@ -113,10 +113,10 @@ function field_features_export_render($module, $data, $export = NULL) {
+        array_push ( $translatables , array("value" => $field['field_instance']['label'], "context" => $field['field_config']['field_name'].':'.$field['field_instance']['bundle'].':label'));

Coding standard (spaces) + why need array_push here?

Here, the new version of the patch.

For the unique array, I did a little helper function to have a unique multi array, maybe you have a better solution.
I don't know why I used array_push, I changed that! :)

For the tab, I resaved my patch with my no configurate gedit, sorry, I changed that too!

Here, the new version of the patch.

For the unique array, I did a little helper function to have a unique multi array, maybe you have a better solution.
I don't know why I used array_push, I changed that! :)

For the tab, I resaved my patch with my no configurate gedit, sorry, I changed that too!

The patch in #7 works fine but the code is a little weird, especially the part that filters the array of translatables.

I re-rolled it and used a simpler approach of generating the t() calls in an array of strings, and then I filter duplicate lines.

ALSO: My patch adds support for translatables for the 'allowed values' of a select box. This could be a separate issue, but since allowed_values also need a special context, it is easier to do it in a single patch.

The code in the last patch works but perhaps there should be a check whether the allowed values have empty labels or not. I've added that in the patch.

Here is the patch for Features 2, based on the #10 patch.

the first changes contain some coding issues, should likely run it through coder

Seems like this also generates the header comment text even if there aren't any translatables.

Attached is a patch that fixes a bug in translating descriptions and fixes the coding style errors.

Hmm I can't seem to find anything wrong with my patch. Anyone with a clue?

Another try then ;-)

Gah

Just formatting the text and fixing minor typos

What else is needed to get this included?

Works for me, thanks. Hopefully it'll get in soon!

Sorry just looking over this briefly, would this break any current translations of the items with added context?

Current translations just don't work when textgroup is anything but 'default'.

But t() (with context) is not how i18n_strings are translated so would this even work? Potx would produce a file with default translations mixed with translations with contexts but those would still be default translations, right? How would the import process go to separate the strings into different text groups?

@mikran : You are right that by itself this patch is not enough.

You also need to patch the string export and import modules so the context and textgroup is preserved the whole way around.

In our case, we are using the potx module to export translations which we patched and we use l10n_update to re-import which we also patched.

So for us a total of 3 patches was requires to get everything to 'work'.