Problem/Motivation
On file field widget configuration forms, the user is presented with this text to help in choosing between throbber and progress bar:
The throbber display does not show the status of uploads but takes up space. The progress bar is helpful for monitoring progress on large uploads.
The word "less" is missing.
Proposed resolution
Change the text to:
The throbber display does not show the status of uploads but takes up less space. The progress bar is helpful for monitoring progress on large uploads.
Remaining tasks
There is some discussion below as to whether the setting should even exist, or whether the text makes sense at all. These issues should possibly be addressed in the future. The patch itself merely corrects what is clearly a typo.
User interface changes
String change: On file field widget configuration forms, the description will change from:
The throbber display does not show the status of uploads but takes up space. The progress bar is helpful for monitoring progress on large uploads.
to:
The throbber display does not show the status of uploads but takes up space. The progress bar is helpful for monitoring progress on large uploads.
API changes
(API changes/additions that would affect module, install profile, and theme developers, including examples of before/after code if appropriate)
Original report by @mlncn
When editing an imagefield, for instance, the user is presented with this text to help in choosing between throbber and progress bar:
"The throbber display does not show the status of uploads but takes up space. The progress bar is helpful for monitoring progress on large uploads."
I think the word "less" is missing in the first sentence? Unless the author really doesn't like throbber!
Shall i roll a patch to change the text to:
"The throbber display does not show the status of uploads but takes up less space. The progress bar is helpful for monitoring progress on large uploads."
Comment | File | Size | Author |
---|---|---|---|
#2 | throbber-filefield-text-correction-848546-1.patch | 987 bytes | mlncn |
Comments
Comment #1
webchickLOL. Yeah, sounds good.
Comment #2
mlncn CreditAttribution: mlncn commentedIn a small way, this is a usability issue. Patch attached.
Comment #3
mlncn CreditAttribution: mlncn commentedCrosspost- just correcting the component back, here. I didn't even know user interface text was an option, heh.
Comment #4
Dries CreditAttribution: Dries commentedSeems like a silly setting to begin with.
Comment #5
tstoecklerRe #4:
I think what users will experience is that they have an uploadprogress bar on their local site (that's the default setting, right?), then push the site to their shared hosting and just see the throbber, because on that server the extension is not installed.
For that reason I would either:
a. never show this setting which means less UI for most users and a bit confusion for the above mentioned users.
b. always show this setting (also when the extension is not installed) which means more confusing (?) UI for all users but no confusion for the above users.
Currently we only show the setting if the extension is installed. I agree with Dries that that doesn't make much sense.
Comment #6
henrrrik CreditAttribution: henrrrik commentedThis is a no-brainer, no? The current text stating that the throbber "does not show the status of uploads but takes up space" doesn't make any sense.
Comment #7
yoroy CreditAttribution: yoroy commentedI would prefer to drop this setting from core, pick an option already and make it easy to override/customize it.
Comment #8
henrrrik CreditAttribution: henrrrik commentedSwitching this back to 7.x. This issue just concerns a typo. I think a functional change for 8.x should have its own issue.
Can someone please commit this? It's a one word change.
Comment #9
yoroy CreditAttribution: yoroy commentedEven typos get fixed in current head first, then possible backported. I'm fine with keeping this issue limited to that.
Comment #10
droplet CreditAttribution: droplet commented"The throbber display does not show the status of uploads"
It doesn't make sense, it show an icon to you.
Comment #11
henrrrik CreditAttribution: henrrrik commentedCan we create a new separate issue if we are to dive into the semantics of this? That way we can get this typo fixed and anyone who wants to work on improving the rest of the message can do that until the end of time if they like.
This issue celebrates 1 year next week. One year to fix a typo.
Comment #12
xjmTagging issues not yet using summary template.
Comment #12.0
xjmUpdated issue summary.
Comment #12.1
xjmBetter formatting.
Comment #13
xjmSummary added, such as it is.
Comment #14
sunIndeed, this typo is ridiculous. Removing the setting in D8+ can be done afterwards, in this or in a new issue.
Comment #15
Dries CreditAttribution: Dries commentedCommitted to 8.x. Moving to 7.x for webchick.
Comment #16
webchickLOL! That's a pretty funny typo. :)
We normally don't break strings in stable releases for minor changes like this. But in this case the string is actually wrong, so I think fixing it makes sense. it's also a string buried in an admin page so hopefully won't affect too many people.
Committed and pushed to 7.x. Thanks.
Comment #17.0
(not verified) CreditAttribution: commentedMeh, whitespace.