RTL support css file [#1294012]

Thank you for making this great base theme!

I reviewed the theme rtl support and added all needed css:

1. Added /* LTR */ marking to original css files
2. Created or modified corresponding rtl css files
3. Added rtl images (attached below)

The following guidelines were considered:

Original css file	RTL css file
Adding a css property that has "right" (or "left") as value ex: `float:left;`	The same property should be added with value "left" (or "right") ex: `float:right;`
Adding the css property "left" (or "right") ex: `left:20%;`	Property "left" (or "right") should be reverted to "auto", and "right" (or "left") set to the same value ex: `left:auto; right:20%;`
Adding properties like padding, margin, background-position ... examples: `padding-left:20px;` `margin:10px 5px 20px 15px;` `background:url(images/decline.png) no-repeat right top;`	"left" and "right" values should be swapped; If only one is set the other should be reset to default value (0 for paddings and margins) if required ex: `padding-left:0; padding-right:20px;` `margin:10px 15px 20px 5px;` `background:url(images/decline.png) no-repeat left top;`
Adding a background image that has a relation with language direction (for example an arrow from left to right) ex: `background-image:url(images/arrow.png);`	A new rtl image should be created from the original with required changes, and the corresponding css adjusted to point to it ex: `background-image:url(images/arrow-rtl.png);`

Note: patch generated in 7.x-3.0 version

Regards

File	Size	Author
omega_rtl_images.tar_.gz	6.92 KB	ahwebd
omega_rtl.patch	43.3 KB	ahwebd
alpha_rtl.patch	140.92 KB	ahwebd

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ahwebd CreditAttribution: ahwebd commented 30 September 2011 at 06:56

Version:

7.x-3.0

» 7.x-3.x-dev

Comment #2

ahwebd CreditAttribution: ahwebd commented 27 November 2011 at 08:30

no one?

Comment #3

Cellar Door CreditAttribution: Cellar Door commented 17 February 2012 at 20:14

Assigned:

Unassigned

» himerus

Thanks for the patch!

Comment #4

himerus CreditAttribution: himerus commented 17 February 2012 at 22:28

Status:

Needs review

» Needs work

alpha_rtl.patch does not apply cleanly to latest 7.x-3.x dev.

Checking patch alpha/css/alpha-alpha-rtl.css...
Checking patch alpha/css/alpha-alpha.css...
Checking patch alpha/css/alpha-debug-rtl.css...
Checking patch alpha/css/alpha-debug.css...
Checking patch alpha/css/alpha-mobile.css...
error: while searching for:
  position: relative;
  margin-left: 10px;
  margin-right: 10px;
}
error: patch failed: alpha/css/alpha-mobile.css:8
error: alpha/css/alpha-mobile.css: patch does not applyalpha_rtl.patch does not apply cleanly to latest 7.x-3.x dev.

I'd love to see this get in, but will be moving it the 3.2 release roadmap... and that being said, in 3.2 the CSS is going to wildly change, and the current css will still be present for legacy sites, but a new, cleaner version of CSS styling will be enabled in newer versions.

@ahwebd will you be willing to A.) update this patch to apply cleanly to latest dev version, and B.) work with us on the updated CSS coming in 3.2 to ensure it is properly RTL compliant?!

Comment #5

ahwebd CreditAttribution: ahwebd commented 18 February 2012 at 18:22

Thanks for all your efforts himerus, I'll be really happy to work on this (a & b) when time permits.

Comment #6

i2man CreditAttribution: i2man commented 22 July 2012 at 21:26

Title:

RTL support

» RTL support css file

Hi all, i am new to Druplal, i am working on site with two languages ( French (ltr) and Arabic (rtl), i am using Omega 3 for theming with subtheme, i implemented all the files provided with this theme, the problem is on Arabic (rtl) section, i want to note that languages are added perfectly, i can switch between theme with no problem Ltr and Rtl, the issue is when i want to theme RTL section with custom file css that do not exist in the package of Omega, how to add this file that will be styled separatly for the Arabic section with graphics and fonts, i know the file global.css is perfect but juste for French section, i made some searching and find LESS but the problem is already how to add this CSS file to my Subtheme CSS folder, i need your help please.
Thanks all