Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I tried to integrate the module into linkchecker... Added 1000 urls from d.o into httprl_request()
... We need to solve #1268096: Implement a rate limiter asap.
Incomplete responds array:
I guess my action killed my local server I fired the stuff, too.
So what's the problem?
Status
== "Done"Code
is missing. Really need this value!Status_message
is missing.
Comment | File | Size | Author |
---|---|---|---|
#8 | httprl-1419672-8-make-responds-object-more-complete.patch | 1.31 KB | mikeytown2 |
#6 | 1419672+Responds+object+incomplete+and+inconsistent.patch | 592 bytes | hass |
#5 | 1419672+Responds+object+incomplete+%2F+inconsistent.patch | 592 bytes | hass |
#3 | 2012-01-29_032521.png | 20.54 KB | hass |
2012-01-28_145332.png | 26.07 KB | hass |
Comments
Comment #0.0
hass CreditAttribution: hass commentedEmbedded link is defect
Comment #0.1
hass CreditAttribution: hass commentedfoo
Comment #1
hass CreditAttribution: hass commentedI've seen one more variant where the "error" and "code" was below "request". This means
$foo->request->error
and$foo->request->code
and missing in root of Class. It must always be$foo->code
and$foo->error
.$foo->code
is required in all cases, error is optional.Comment #1.0
hass CreditAttribution: hass commentedfff
Comment #2
hass CreditAttribution: hass commentedComment #3
hass CreditAttribution: hass commentedExample dump for #1 bug
Comment #4
hass CreditAttribution: hass commentedAdded 2 lines (Line 350ff) in function
httprl_send_request()
: $result->code and $result->errorComment #5
hass CreditAttribution: hass commentedPatch for #4. It does not fix the redirect inconsistency bug(s).
Comment #6
hass CreditAttribution: hass commentedRe-attach patch with changed name as %2F cause problems on d.o. The (int) is there as it seems to be possible that this is sometimes not an int what is not allowed, but I've seen it... no idea why.
Comment #7
hass CreditAttribution: hass commentedWith more thinking it may be better to refactor/review the full logic to prevent such consistencies in general. What i've done here was a quick fix that may break in other situations... Not sure.
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedPushed the casting to an INT higher up in the code. Patch below committed to 6.x & 7.x.
Comment #9
hass CreditAttribution: hass commentedDoes this also fix the "redirect" inconsistencies compared to core?
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedI think it might, only one way to find out ;)
#1320222-3: Bring in other drupal patches
Comment #11.0
(not verified) CreditAttribution: commentedfoo