Project Page and Git repository
http://drupal.org/sandbox/eleonel/1683916

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/eleonel/1683916.git xurxo
cd xurxo

PAReview: http://pareview.sh/pareview/httpgitdrupalorgsandboxeleonel1683916git

Version

Drupal version: 7x

Screenshot

Xurxo Theme

Overview

Xurxo is a theme designed for radio stations websites.

Features

  • Responsive: Tested in tablets and mobile devices.
  • SASS: All the css files are generated with sass :)
  • Many regions: Header, Superfish Menu, Highlighted, Banner, Preface One, Preface Two, Preface Three, Content, Sidebar First, Sidebar Second, Post Content, Bottom One, Bottom Two, Bottom Three, Bottom Four, Footer.

Requirements

Drupal 7.x, jQuery Update and Responsive Menus.

Sites that use Xurxo Theme

Tell me about your site here.

Reviews of other projects

http://drupal.org/node/1683092#comment-6233262
http://drupal.org/node/1682682#comment-6233248
http://drupal.org/node/1591818#comment-6033430

CommentFileSizeAuthor
#8 footer.jpg4.88 KBketelagoreng
#8 sidebar.jpg8.14 KBketelagoreng
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi’s picture

Welcome!

You have to set the status to "needs review" if you want to get a review. You have listed some reviews in your issue summary, but you did not do any manual reviews? Please read through the source code of other projects and report any issues that you find. And don't forget to add the review bonus tag if you did some actual manual reviews as outlined in #1410826: [META] Review bonus.

eleonel’s picture

Status: Active » Needs review
nitvirus’s picture

Status: Needs review » Needs work

Manual review:
In styles/block.css
line number 6: there should be space after ":"
line number 9: there should be space after ":"
line number 25, 31: use lowercase in hexcolor codes.
suggestion: try using #fff hex color code instead of white
line number 46: css properties should be in alphabetical order.

Same way in style.css: use lowercase in hexcolor codes. at line number 572, 462, 458
in style.css there are spacing issues.

eleonel’s picture

D4Ko’s picture

Please take a moment to make your project page follow tips for a great project page.

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

eleonel’s picture

Done.

Thanks!

eleonel’s picture

Status: Needs work » Needs review
ketelagoreng’s picture

FileSize
8.14 KB
4.88 KB

hi eleonel,

It's a nice theme, but I got some problems here. Please looks some picts I attached.
pict 1: unreadable title post at footer
pict 2: it's not a bad idea to give some padding

ketelagoreng’s picture

Status: Needs review » Needs work
eleonel’s picture

Status: Needs work » Needs review

hi, thanks for your feedback. Fixed!

eleonel’s picture

Issue summary: View changes

Adding screenshot section :)

zymphonies-dev’s picture

Status: Needs review » Needs work

Hi eleonel,

Manual review:
1) Please upload screenshot in this page
2) add menu active style and you can give menu divider

#navigation a.active {
    background: none repeat scroll 0 0 #FFFFFF;
    color: #E34212;
}
#navigation li{
   border-right: 1px solid #CCC;
   /*-- you can choose any other border color ---*/
}

3) LHS block not floated ( screenshot attached)

.sidebar .gutter .block{
    float: left;
    width: 100%;
}

Regards,
Team Zymphonies

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

eleonel’s picture

Status: Closed (won't fix) » Needs review

Thanks. Fixed!

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxeleonel1683916git

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Resize screenshot image ;)

eleonel’s picture

Issue summary: View changes
Status: Closed (won't fix) » Needs review

Hi, I add Sass and I did a refactoring to the code. Please review.

Cheers

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2262435

Project 2: https://drupal.org/node/1683924

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

eleonel’s picture

Status: Closed (duplicate) » Needs review
eleonel’s picture

Title: Xurxo Theme » [D7] Xurxo Theme
magicleaves’s picture

Status: Needs review » Needs work

Hello eneonel,

  1. You have to remove the master branch from Git.
  2. README.txt or README.md is missing. You can check the guidelines here.
eleonel’s picture

Status: Needs work » Needs review

* Removed master branch
* Added Readme file.

magicleaves’s picture

Status: Needs review » Needs work

Visit http://pareview.sh/pareview/httpgitdrupalorgsandboxeleonel1683916git

You will find the following issues with about your module.

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
11 | WARNING | Line exceeds 80 characters; contains 212 characters
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/styles/blocks.css
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
49 | ERROR | Multiple selectors should each be on a single line
49 | ERROR | Multiple selectors should each be on a single line
49 | ERROR | Multiple selectors should each be on a single line
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/styles/blog.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Multiple selectors should each be on a single line
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/styles/layout.css
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Multiple selectors should each be on a single line
19 | ERROR | Multiple selectors should each be on a single line
84 | ERROR | Multiple selectors should each be on a single line
89 | ERROR | Multiple selectors should each be on a single line
95 | ERROR | Multiple selectors should each be on a single line
107 | ERROR | Multiple selectors should each be on a single line
--------------------------------------------------------------------------------

eleonel’s picture

Issue summary: View changes
eleonel’s picture

Status: Needs work » Needs review

Fixes all the code standars issues. Check again please.

Cheers.

eleonel’s picture

Priority: Normal » Major
PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/1683924

Project 2: https://www.drupal.org/node/2262435

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Bevan’s picture

Status: Needs review » Reviewed & tested by the community

I manually reviewed most of the code. Looks great to me!

heddn’s picture

Issue summary: View changes
heddn’s picture

Status: Reviewed & tested by the community » Fixed

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder: http://pareview.sh/pareview/httpgitdrupalorgsandboxeleonel1683916git

  1. styles.scss Unit of measure 0px is redundant at line 65, 373, 396
  2. styles.scss Property text-decoration duplicates property text-decoration at line 353, 393
  3. styles.scss Property list-style-image duplicates property list-style at line 671, 741

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt
Yes: Follows the guidelines for in-project documentation and the README.txt Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes. If "no", list security issues identified.
Coding style & Drupal API usage
  1. template.php: Missing "Implements hook_foo().
    /**
     * Set count variables so column numbers can be dynamic.
     */
    function xurxo_preprocess_page(&$vars) {

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

See there are no blockers...

Thanks for your contribution, Eleonel!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.