Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1921996: Convert system_config_form() to implement FormInterface as a base class. adds a base class to allow FormInterface to mimic system_config_form(). We should convert all of them to it. This is the meta for that.
These are currently the only modules that use system_config_form().
Comment | File | Size | Author |
---|---|---|---|
#7 | system_config_form-1924990-7.patch | 2.37 KB | tim.plunkett |
Comments
Comment #0.0
tim.plunkettassigning user to me
Comment #0.1
tim.plunkettremoved stray *
Comment #1
tim.plunkettOkay, I did user and aggregator as examples.
All conversions should use routes and be defined as a service ID, so that config.factory can be injected in.
Aggregator has the additional example of how to inject other dependencies.
Comment #1.0
tim.plunkettadded aggregator issue
Comment #1.1
tim.plunkettadded book
Comment #2
larowlanAdded #1925252: Convert forum's system_config_form() to SystemConfigFormBase
Comment #2.0
larowlanUpdated issue summary.
Comment #2.1
tim.plunkettUpdated issue summary.
Comment #2.2
tim.plunkettUpdated issue summary.
Comment #3
catchI don't want to convert any more routes as services until #1915774: Decide whether core route controllers should generally/always be DIC services or not is resolved. This is exactly the sort of service bloat I'm concerned about in the other issue.
Comment #3.0
catchUpdated issue summary.
Comment #3.1
ACF CreditAttribution: ACF commentedadded search
Comment #4
YesCT CreditAttribution: YesCT commentedok. 1915774 was committed. it's waiting on a change notice, so that's why it's open. We can proceed creating the rest of the conversion issues. Since there are examples already, I'm tagging with novice.
When creating the issues, look at the examples already in the issue summary and be sure and update this issue summary and link the issues together.
Comment #4.0
YesCT CreditAttribution: YesCT commentedUpdated
Comment #4.1
ACF CreditAttribution: ACF commentedAdded simpletest issue.
Comment #4.2
ACF CreditAttribution: ACF commentedAdded simpletest issue properly
Comment #4.3
ACF CreditAttribution: ACF commentedAdd statistics issue.
Comment #4.4
ACF CreditAttribution: ACF commentedAdd update issue
Comment #4.5
floretan CreditAttribution: floretan commentedAdd link to the menu module issue.
Comment #4.6
floretan CreditAttribution: floretan commentedIndicate the menu module issue is assigned to me.
Comment #5
amateescu CreditAttribution: amateescu commentedI've rerolled aggregator, update and user (#1925048-6: Convert aggregator's system_config_form() to SystemConfigFormBase, #1937998-2: Convert update's system_config_form() to SystemConfigFormBase and #1924992-9: Convert user's system_config_form() to SystemConfigFormBase) to account for #1934832: Provide a dedicated approach for using forms in routes which got committed in the meantime.
All the other patches need to follow the new pattern for converting forms, the main difference being that you no longer have to create a service for each form class. More details and examples are in #1934832: Provide a dedicated approach for using forms in routes.
Comment #6
amateescu CreditAttribution: amateescu commentedAdd sprintweekend tag.
Comment #6.0
amateescu CreditAttribution: amateescu commentedAdd locale issue.
Comment #7
tim.plunkettWe can now kill off system_config_form()! Yay
Comment #8
jibranYay!!
Comment #9
alexpottNeed to update https://drupal.org/node/1910694
Comment #10
tim.plunketthttp://drupalcode.org/project/drupal.git/commit/1356c25
Comment #11
tstoecklerUpdated the notice: https://drupal.org/node/1910694/revisions/view/2680038/2742025