Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1938600: Add a FormInterface replacement for confirm_form() adds a base class to allow FormInterface to mimic confirm_form(). We should convert all of them to it. This is the meta for that. Please see the change notice below for sample conversion.
Part of #1971384: [META] Convert page callbacks to controllers
Related issue #2011018: Reconcile entity forms and confirm forms
These are currently the only modules that use confirm_form().
Comments
Comment #1
tim.plunkettTagging. Please tag any sub-issues you create with FormInterface as well.
Comment #1.0
tim.plunkettI'll play.
Comment #1.1
tim.plunkettUpdated issue summary.
Comment #1.2
jibranUpdated issue summary.
Comment #1.3
jibranUpdated issue summary.
Comment #1.4
mtiftUpdated issue summary.
Comment #1.5
mtiftUpdated issue summary.
Comment #1.6
mtiftUpdated issue summary.
Comment #1.7
mtiftUpdated issue summary.
Comment #1.8
mtiftUpdated issue summary.
Comment #1.9
mtiftUpdated issue summary.
Comment #1.10
mtiftUpdated issue summary.
Comment #1.11
mtiftUpdated issue summary.
Comment #1.12
mtiftUpdated issue summary.
Comment #1.13
mtiftUpdated issue summary.
Comment #1.14
mtiftUpdated issue summary.
Comment #1.15
mtiftUpdated issue summary.
Comment #1.16
mtiftUpdated issue summary.
Comment #1.17
mtiftUpdated issue summary.
Comment #1.18
mtiftUpdated issue summary.
Comment #1.19
mtiftUpdated issue summary.
Comment #1.20
mtiftUpdated issue summary.
Comment #1.21
mtiftUpdated issue summary.
Comment #1.22
mtiftUpdated issue summary.
Comment #1.23
mtiftUpdated issue summary.
Comment #1.24
mtiftUpdated issue summary.
Comment #1.25
mtiftUpdated issue summary.
Comment #1.26
kim.pepperAdded myself for contact module
Comment #1.27
tim.plunkettused the fancy @ thing i didn't know about
Comment #1.28
kim.pepperAssign kim.pepper to path issue
Comment #1.29
mtiftUpdated issue summary.
Comment #1.30
mtiftUpdated issue summary.
Comment #1.31
mtiftUpdated issue summary.
Comment #1.32
mtiftUpdated issue summary.
Comment #1.33
kim.pepperAdded myself to action module
Comment #1.34
kim.pepperAdd myself to image
Comment #2
andypostRelated issue #1842036: [META] Convert all confirm forms to use modal dialog
Comment #3
yched CreditAttribution: yched commentedPeople have been trying to help with #1946404: Convert forms in field_ui.admin.inc to the new form interface, but stumbled on the corresponding menu items currently being defined in a foreach, and thus the need to go through RouteSubscriber / RouteEnhancer (or something :-))
Any knowledgeable people to provide docs or code pointers on the correct way to leverage that over there ?
Comment #3.0
yched CreditAttribution: yched commentedUpdated issue summary.
Comment #3.1
tim.plunkettUpdated issue summary.
Comment #4
jibran#1842036: [META] Convert all confirm forms to use modal dialog is postpone on this as per #1842036-50: [META] Convert all confirm forms to use modal dialog.
Comment #5
jibranWe are really close.
#1938318: Convert book_remove_form to a new-style Form object is pending on #1947880: Replace node_access() by $entity->access().
#1946348: Convert all of confirm_form() in comment.admin.inc to the new form interface needs new patch.
#1946466: Convert all confirm_form() in user.module and user.pages.inc to the new form interface and convert route is ready needs re-roll.
#1946456: Convert taxonomy_term_confirm_delete() and taxonomy_vocabulary_confirm_delete() to the new form interface is ready.
#1946462: Convert content_translation_translatable_form() to the new form interface is committed but has produced regression.
Comment #5.0
jibranadded link to callback meta
Comment #5.1
jibranUpdated issue summary.
Comment #5.2
tim.plunkettupdated
Comment #6
tim.plunkett#1945406: [meta] Convert all of confirm_form() to ConfirmFormBase will be the final issue, after:
#2086479: Convert content_translation_delete_confirm() to the new form interface
#1938318: Convert book_remove_form to a new-style Form object
Comment #7
webchickJust committed those two, so I think we can close this out.
Comment #8
tim.plunkettI meant to link to #2149263: Remove confirm_form(), not to this issue.
Comment #9
Crell CreditAttribution: Crell commentedSmall followup: #2150141: Remove confirm_form() and company
Comment #10
jibranYay!!! Now back to work at #1842036: [META] Convert all confirm forms to use modal dialog.