Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue #2002486 by crowdcg, oenie, shixish, dawehner : Rename Views method even_empty() to evenEmpty()
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#16 | core-rename_even_empty_TO_evenEmpty-2002486-16.patch | 3.6 KB | seantwalsh |
#10 | core-rename_even_empty_TO_evenEmpty-2002486-10.patch | 3.55 KB | seantwalsh |
#8 | core-rename_even_empty_TO_evenEmpty-2002486-8.patch | 3.65 KB | seantwalsh |
#4 | 2002486-added-access-modifier-4.diff | 3.65 KB | shixish |
#4 | interdiff.txt | 1.83 KB | shixish |
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 7 instances of even_empty with evenEmpty.
Comment #3
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #4
shixish CreditAttribution: shixish commentedAdded public to the function definitions.
Comment #5
shixish CreditAttribution: shixish commentedComment #6
oenie CreditAttribution: oenie commentedLooks fine by me.
Comment #8
seantwalshSubmitting updated patch for retesting.
Comment #9
dawehnerThanks for all your help!
Let's do a @inheritdoc, please
Comment #10
seantwalshSorry about that, updated with {@inheritdoc}.
Comment #11
dawehnerAnother issue, great!
Comment #13
dawehner#10: core-rename_even_empty_TO_evenEmpty-2002486-10.patch queued for re-testing.
Comment #15
joelpittetLooks like the new line was meant to replace the line 3 rows down from that one.
Comment #16
seantwalshThanks, not sure what happened there. This one should pass.
Comment #17
joelpittetAlready RTBC'd by @dawehner in #11 and it's green now. So back to it:) Thank you @crowdcg
Comment #18
alexpottCommitted c4e1535 and pushed to 8.x. Thanks!
Comment #19.0
(not verified) CreditAttribution: commentedUpdated issue summary. Added commit line.