Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal-viewsRename-operator_form-2003438-10.patch.patch | 5.78 KB | heddn |
#8 | rename_operator_form-2003438-8.patch | 4.43 KB | trevjs |
#6 | rename_operator_form-2003438-6.patch | 4.71 KB | trevjs |
#1 | 8.x-dev-rename_operator_form.patch | 640 bytes | trevjs |
Comments
Comment #1
trevjs CreditAttribution: trevjs commentedComment #2
trevjs CreditAttribution: trevjs commentedComment #3
trevjs CreditAttribution: trevjs commentedComment #5
trevjs CreditAttribution: trevjs commentedComment #6
trevjs CreditAttribution: trevjs commentedForgot to change callers. Also specified public calling method. In some cases it is called by show_operator_form, and so it may be that this is intended to be a private method. Let me know and I'll change it.
Comment #8
trevjs CreditAttribution: trevjs commentedRe-roll
Comment #9
oenie CreditAttribution: oenie commentedHate to throw this back again, but it seems you have missed a spot:
core/modules/search/lib/Drupal/search/Plugin/views/filter/Search.php, line 51:
function operator_form(&$form, &$form_state) {
Be sure to add the access modifier in front of the function as well.
Actually, since the only call to the operatorForm method seem to be on a $this instance, it could actually be protected instead of public.
Comment #10
heddnIt also needed a re-roll. Here goes.
Comment #11
oenie CreditAttribution: oenie commentedLooks good to me !
Comment #12
alexpottCommitted 85ad766 and pushed to 8.x. Thanks!
Comment #13.0
(not verified) CreditAttribution: commentedlink to meta issue