Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
part of #2011290: [meta] standards cleanup to get ready for getting into core
Clean up the following file:
http://drupalcode.org/project/config_translation.git/blob/HEAD:/config_t...
Proposed resolution
Remaining tasks
User interface changes
No
API changes
No
Comment | File | Size | Author |
---|---|---|---|
#8 | config_translation.module.2017887.8.patch | 560 bytes | robertdbailey |
Comments
Comment #1
robertdbailey CreditAttribution: robertdbailey commentedComment #2
robertdbailey CreditAttribution: robertdbailey commentedComment #3
YesCT CreditAttribution: YesCT commented#1938580: [META] Make active config save format match the default yml file (order and quotes) might be of use while looking at this one.
[edit: no, this isn't config or schema...]
Need to find another example of services.yml in core.
Comment #4
YesCT CreditAttribution: YesCT commentedComment #4.0
YesCT CreditAttribution: YesCT commentedupdated UI/API changes sections to include "no"
Comment #5
YesCT CreditAttribution: YesCT commentedHere is one to compare:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/core.services.yml
Comment #6
YesCT CreditAttribution: YesCT commentedIn views:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/views/v...
the name is in single quotes and there is a space before the }
in core:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/core.services.y...
We have:
So, I dont see anything blocking here.
I'm not even sure if there is anything to change.
Are these services.yml files hand written, or saved?
Comment #7
YesCT CreditAttribution: YesCT commentedhttps://drupal.org/node/1937056
might be a change notice that says how to write it.
Oh, I should use blame and see which issue added this file.
#1985880: Convert to routing system
which references the WSCII conversion guide: https://drupal.org/node/1953342
I guess someone could add a space before the end }'s
Aside from that. It's fine as far as I can tell.
Comment #8
robertdbailey CreditAttribution: robertdbailey commentedComment #9
YesCT CreditAttribution: YesCT commentedthis look just fine! :) Thanks.
Comment #10
Gábor HojtsySuperb, thanks, committed.
Comment #11.0
(not verified) CreditAttribution: commentedadded file link to description