Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Description
This module adds an exposed form style: Hidden.
When an exposed form is hidden, the results of Views still can be filtered or sorted by changing URL.
Links
- Project page: Views Hide Exposed Form
- Git repository: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/lchang/2081467.git views_hide_exposed_form
Comments
Comment #1
lchang CreditAttribution: lchang commentedPAReview: review bonus
Comment #2
alexmoreno CreditAttribution: alexmoreno commentedyou have some minor issues that you should correct:
Comment #3
Ayesh CreditAttribution: Ayesh commentedHi,
Believe me I was working on a View with an attachment+exposed filters that I really needed this module!
One thing is that the project description is too short. Module worked great for me.
Comment #4
lchang CreditAttribution: lchang commentedHi, urwen
These are coding standards of Views.
Comment #5
lchang CreditAttribution: lchang commentedHi, Ayesh
Thank you for using this module!
The function of this module is straightforward, so the project description is short.
Comment #5.0
lchang CreditAttribution: lchang commentedAdd Reviews of other projects.
Comment #6
alexmoreno CreditAttribution: alexmoreno commentedcorrect me if I am wrong, but this module does not meet the minimum requirements to be reviewed. Basically, the code without including views inc is too short. 15 lines for the .module, with just one function.
Point 2.3 in Project application checklist: https://drupal.org/node/1587704
Thank you.
Comment #7
tibezh CreditAttribution: tibezh commentedIf that fails for whatever reason please get back to us and set this back to "needs review".
Comment #8
lchang CreditAttribution: lchang commentedComment #9
bohartIchang, functional your module not enough to create a new module. It is enough to create a patch to the module Views exposed autohide.
Comment #10
lchang CreditAttribution: lchang commentedComment #11
takim CreditAttribution: takim commentedI also agreed with the point , we dont need to install a new module for this. It is very small changes , and you can do it in hook functions of views or just hiding through css. To have such a small module enabled in site making site slow. So it would say you could extend it in more so it can have some more features with views.
Comment #12
lchang CreditAttribution: lchang commentedHi, takim
Make sites load fast, that's why this module is small.
Comment #13
PA robot CreditAttribution: PA robot commentedProject 1: https://drupal.org/node/2089425
Project 2: https://drupal.org/node/2081543
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14
lchang CreditAttribution: lchang commentedComment #15
Martin Schauer CreditAttribution: Martin Schauer commentedHi Ichang,
I had a look at your project.
The code looks straight forward to me and it's working as supposed, so basically there is nothing to criticize, well done!
Still I found some probably not too important things to mention here:
A comment in the disable-hook of your .install-file would be helpful and could save possible co-workers some time figuring that out.
Typo in views_hide_exposed_form_plugin_exposed_form_hidden.inc: "Exposed form plugin that hides a exposed form." It should be "an exposed form" here.
Typo in views_hide_exposed_form.module: "Hides the Views exposed form." It should be "View's" here.
Nothing critical at all, so there is no need to change the status to "needs work". Anyway I have to agree with @bohart and @takim, the module's code is really minimalistic, though its functionality is quite useful. Maybe you should consider working together with Views, Better exposed filters or any module that already deals with the behaviour of exposed filters, to save the time of Drupal-users they need to find out that there is a additional module available and required for their usecase.
Basically this project's code would be ready to receive the RTBC-status, but this sure is something to think about before changing the status.
regards,
Martin
Comment #16
lchang CreditAttribution: lchang commentedHi Martin,
Thanks for your review!
Comment #17
Ayesh CreditAttribution: Ayesh commentedHi lchang,
While I'm excited to see you have contributed something I exactly wanted, I'd like you to pay attention to what others have said about "enough code" and project merging. Promoting a module from sandbox to a real project and getting the vetted status are two different stuff. I believe maintainers of Better Exposed filters or other similar modules would gladly commit patches if you submit them and give you the full credit.
IMHO, setting the status to "needs review" will only make things slower.
Comment #18
kscheirerThis module seems most appropriate as a patch to the existing Views module (now in core). It's adding exactly one option to the concept of an exposed filter. I would encourage you to open an issue there to get some feedback on the idea. If the Views maintainers really don't want it, then a separate module is the way to go.
If that fails for whatever reason please get back to us and set this back to "needs review".
I don't think this is a useful feature though. Edit: I just read Ayesh's commment again, and his idea to provide this as a patch to Better Exposed Filters is a good one too!
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #19
lchang CreditAttribution: lchang commentedComment #20
kscheirerWell, that's too bad, I did think it was a very useful feature. Anyone else want to write a patch for Better Exposed Filter?
Comment #20.0
kscheirerUpdated description