[D7] Disqus import

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Add drupal version.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsanchiz1999128git

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I see you are calling "variable_get('disqus_domain', '')" in "disqus_import.admin.inc" line 26 but I am no able to see where do you set this variable.

Have you considered to use the migrate API for this? I don´t know the Third party API services but It seems like a good choice. https://drupal.org/project/migrate

Regards

Hi sanchiz,

I am getting the following notice and warnings if I do not upload the Disqus import XML file and click Import. So please validate that Import File field and display the message, if the XML file has not been uploaded.

Notice: Undefined index: xml in disqus_import_admin_settings_submit() (line 76 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).
Notice: Trying to get property of non-object in disqus_import_admin_settings_submit() (line 80 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).
Warning: Invalid argument supplied for foreach() in disqus_import_admin_settings_submit() (line 80 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).
Notice: Trying to get property of non-object in disqus_import_admin_settings_submit() (line 91 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).
Warning: Invalid argument supplied for foreach() in disqus_import_admin_settings_submit() (line 91 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).
Notice: Undefined index: count in disqus_import_batch_finished() (line 196 of /Applications/MAMP/htdocs/theme/sites/all/modules/custom/disqus_import/disqus_import.admin.inc).

Thanks,
Ramesh

Thanks for working on this module. Here is some manual review comments:

1. Some tips from pareview.sh - There is still a master branch, make sure to set the correct default branch: [#1659588] . Then remove the master branch, see also step 6 and 7 in [#1127732]

2. $form_state['values']['file'] = $file; - Seems this is not used anywhere in _submit(). Do we really need it form_state?

3. There is no .test to cover the functionalities of this module.

4. if (node_load($comment->nid)) { - if we are going to load N number of comments, we do N node_load to just see if nid is a valid node ID or not. For performance point of view, can we have a helper that just select nid from node and keep static cache, etc so that we don't need to load same node for multiple comments?

5.

  return TRUE;
}

in _submit function. We may need to replace with form_state['redirect'] just leave it. Is there any reason to return it?

Added review.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

The existing disqus module already has the import functionality. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the disqus issue queue to discuss what you need in addition. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Please open a new project application when you need to promote a new project. It only makes sense to approve you as git vetted user when there is new code that is actually going to be promoted to a full project. Otherwise it is a bit of waste of time for reviewers.

Don't let that discourage you, you can already contribute to Drupal in many ways. Make sure to re-use your review bonus on the next application and I will be happy to review it!