We just get an indefinite spinner, and a JS error.

Turns out the issue is menu toggle checks the Drupal.settings['adaptivetheme'][activeTheme] structure, but this isn't added to the modal AJAX request so fails with an undefined variable error.

Attached patch just bails if this structure is not set, which seems reasonable since there aren't actually any menus on the media modal "edit" dialog.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Owen Barton’s picture

Fixed patch

Jeff Burnz’s picture

OK, seems pretty simple, will test as soon as I get time, if anyone else can and RTBC I am cool with committing it.

As you can see its taken me over two weeks to make this one comment, so any help like this is massively appreciated!

Jeff Burnz’s picture

Issue summary: View changes

Fix typo

Jeff Burnz’s picture

Issue summary: View changes
Status: Needs review » Fixed

Committed! Thank-you for your contribution, I attributed you also. Cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.