Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
1. There is no 'status' and 'langcode' elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has type casting.
Proposed resolution
Fix them in the list
Remaining tasks
Fix and issue patch.
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#5 | contact_config-2105927-5.patch | 5.35 KB | a_thakur |
#3 | contact_config-2105927-3.patch | 5.11 KB | a_thakur |
Comments
Comment #1
a_thakur CreditAttribution: a_thakur commentedWent through the following files and could not find any such occurrence of integers, Booleans, octal numbers in config object files as strings.
Changing to reviewed & tested by community
Comment #2
vijaycs85yeah, we don't have type casting, but we do miss few element on default config. Updating issue summary/title to reflect the new scope of this issue.
1. There is no status and language elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has lots of integer in quotes
Comment #3
a_thakur CreditAttribution: a_thakur commentedFixed the following, please review
Comment #3.0
a_thakur CreditAttribution: a_thakur commentedUpdated issue summary.
Comment #4
vijaycs85should be true.
all boolean values should be true/false.
Comment #5
a_thakur CreditAttribution: a_thakur commentedChanged all boolean to true/false.
Comment #6
enhdless CreditAttribution: enhdless commentedLooks good to me!
Comment #7
webchickCommitted and pushed to 8.x. Thanks!