Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There's a lot of methods in service but most of doc-blocks are have no type hinting
Comment | File | Size | Author |
---|---|---|---|
#23 | drupal_2092265_23.patch | 5.74 KB | Xano |
#23 | interdiff.txt | 3.33 KB | Xano |
#20 | drupal8.field-system.2092265-19.patch | 4.64 KB | amateescu |
#19 | drupal_2092265_19.patch | 5.27 KB | Xano |
#12 | interdiff.txt | 548 bytes | andypost |
Comments
Comment #1
andypostInitial patch
Comment #2
yched CreditAttribution: yched commentedNever saw that syntax before, but it seems we start to use it in other places in core... Is that an offical doc standard now ?
Comment #3
yched CreditAttribution: yched commentedWow, Phpstorm actually recognizes this and provides method completion accordingly, that's pretty awesome :-)
Comment #4
andypost@yched yes same here, but dawehner suggested this syntax
Comment #5
andypostThe link to issue #1772420: [policy only] Documentation standard for arrays of a certain type (param/return types)
Comment #6
alexpottPatch no longer applies.
Comment #7
andypostprepareExtraFields()
is goneAlso removed useless
because they are in the same namespace
Comment #8
yched CreditAttribution: yched commentedFieldInstanceInterface[] is not correct, unfortunately, see the description of the @return . The current (arguably bad DX) behavior of the function is to have different return structure depending on the params
The description for the @return is totally invalid now - an $instance structure is not an associative array anymore. Could we fix that while we're in here ?
Comment #9
andypostNice catch!
Comment #10
yched CreditAttribution: yched commentedThanks for being so quick !
Sorry, actually the main description for the getInstance() method is similarly badly outdated :-/
Awkward phrasing. Maybe just "The field instance definition, or NULL if it does not exist" ?
Comment #11
andypost@yched you awesome as always!
Comment #12
andypostComment #13
yched CreditAttribution: yched commentedYay :-)
Thanks !
Comment #15
andypost#12: drupal8.field-system.2092265-12.patch queued for re-testing.
Comment #16
andypostSome strange failure of upgrade tests has happen
Comment #17
andyposttagging
Comment #18
alexpottPatch no longer applies.
Comment #19
XanoRe-roll, and I fixed some more type hints in code comments. I just don't know how to interdiff if there's a patch that no longer applies.
Comment #20
amateescu CreditAttribution: amateescu commentedHere it is.
Comment #21
amateescu CreditAttribution: amateescu commentedNULL -> null in typehints.
What's the reason for removing the description text?
I'd say #20 is RTBC, not #19 :)
Comment #22
Xano#20 forgets to update a few descriptions that still mention array structures.
Comment #23
XanoComment #24
andypostback to RTBC
Comment #25
webchickCommitted and pushed to 8.x. Thanks!