[D7] Ubercart - Optile payment module [#2095737]

uc_optile is a module created to work with Ubercart e-commerce. It features payment solution based on Native WITHOUT PCI implementation using Optile.

Features

Initial LIST request/response
Credit card data validation via AJAX
CHARGE request via AJAX
IPN handler for order completion

Requirements

Ubercart - Drupal e-commerce platform

Project page

https://drupal.org/sandbox/dev-i-WaysHR/2090179

Git

git clone http://git.drupal.org/sandbox/dev-i-WaysHR/2090179.git uc_optile

Comments

Comment #1

PA robot CreditAttribution: PA robot commented 23 September 2013 at 16:23

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #2

TR CreditAttribution: TR commented 26 September 2013 at 22:13

Status:

Needs review

» Needs work

Your .info file needs to have a files[] key for each and every file that contains a class declaration, so that Drupal's class loader can find the files. See https://drupal.org/node/542202

Comment #3

i-Ways.hr CreditAttribution: i-Ways.hr commented 30 September 2013 at 08:06

Status:

Needs work

» Needs review

Thanks for the info. I have removed include_once from the code and defined classes inside file[]

Comment #4

aramboyajyan CreditAttribution: aramboyajyan commented 13 October 2013 at 13:56

Hello,

Here are some quick notes:

Major things:

You should not include the complete Optile SDK in your module. Instead, set a dependency in your module with Libraries API and define download link and require the files that way.
JS code should be added through Drupal behaviors. See Drupal 7 JavaScript API for more details.
Use t() for message string in the UcOptileModelNotification::log() method

Minor details:

Name of the module should be without "Ubercart - ..." and the word "module". For example just "Optile"
Pass the comment through t() function to make it translatable: uc_optile.pages.inc, line 357
Occasional mixing of single/double quotes (e.g. uc_optile.module lines 139 and 143)
It is enough to reference the hook implementation like so: Implements hook_uc_payment_method(). rather than copying the whole comment block from Ubercart.