Hi,

I don't know if this is the right place to report this, forgive-me if it isn't
After D7 migration "drush make" is failing to download drupal core as type=core
drush make fetches this URL: http://updates.drupal.org/release-history/drupal/7.x to get the release history for drupal core and the returned xml is missing the following term:

      <term><name>Projects</name><value>Drupal core</value></term>

This way, drush make doesn't know that drupal is a core project and tries to download it as a module, which results in an error.

It should be returning this:

<?xml version="1.0" encoding="utf-8"?>
<project xmlns:dc="http://purl.org/dc/elements/1.1/">
<title>Drupal core</title>
<short_name>drupal</short_name>
<dc:creator>Drupal</dc:creator>
<api_version>7.x</api_version>
<recommended_major>7</recommended_major>
<supported_majors>7</supported_majors>
<default_major>7</default_major>
<project_status>published</project_status>
<link>http://drupal.org/project/drupal</link>
  <terms>
   <term><name>Projects</name><value>Drupal core</value></term>
   <term><name>Development status</name><value>Under active development</value></term>
   <term><name>Maintenance status</name><value>Actively maintained</value></term>
  </terms>

but is returning this:

<?xml version="1.0" encoding="utf-8"?>
<project xmlns:dc="http://purl.org/dc/elements/1.1/">
<title>Drupal core</title>
<short_name>drupal</short_name>
<dc:creator>Drupal</dc:creator>
<api_version>7.x</api_version>
<recommended_major>7</recommended_major>
<supported_majors>7</supported_majors>
<default_major>7</default_major>
<project_status>published</project_status>
<link>http://drupal.org/project/drupal</link>
  <terms>
   <term><name>Development status</name><value>Under active development</value></term>
   <term><name>Maintenance status</name><value>Actively maintained</value></term>
  </terms>
CommentFileSizeAuthor
#25 project-2126123-project_type_in_release_history.patch3.49 KBjonhattan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexandrezia’s picture

alexandrezia CreditAttribution: alexandrezia commented
Project: Drupal.org site moderators » [Archive] Drupal.org D7 upgrade QA
Component: Other » Code

Changing Project to which I think is the right project to handle this issue

alexandrezia’s picture

alexandrezia CreditAttribution: alexandrezia commented
Title: Site functionality problem » Drupal core release history making drush make fail

Changing title to a more explanatory one

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

The issue in the drush queue https://github.com/drush-ops/drush/issues/234

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Priority: Normal » Critical
sobi3ch’s picture

sobi3ch CreditAttribution: sobi3ch commented

Hi, I've put more info in github issue queue https://github.com/drush-ops/drush/issues/234

sobi3ch’s picture

sobi3ch CreditAttribution: sobi3ch commented
Title: Drupal core release history making drush make fail » Drupal core release history making drush pm-download fail

It's actually pm-download not make. Correct me if I''m wrong.

mavimo’s picture

mavimo CreditAttribution: mavimo commented

Error on all non module projects (core, profile, theme).

sylus’s picture

sylus CreditAttribution: sylus commented

Yeah this is completely killing all of my travis builds. https://travis-ci.org/wet-boew/wet-boew-drupal/jobs/13443522

yuchuan1’s picture

yuchuan1 CreditAttribution: yuchuan1 commented

According to https://github.com/drush-ops/drush/issues/234#issuecomment-27656033
The following change fixed the issue
projects[drupal][type] = core
projects[drupal][version] = 7.23
projects[drupal][download][type] = get
projects[drupal][download][url] = http://ftp.drupal.org/files/projects/drupal-7.23.tar.gz

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

#9is a temporary workaround for folks who use make. the bug still needs to be fixed ASAP. The OP described the problem well - a term is missing from the update xml.

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented

I think Project module is responsible for building the release history XML. Unless I'm mistaken (I haven't tested it) but it seems like this is the code that generates the project terms:

http://drupalcode.org/project/project.git/blob/refs/heads/7.x-2.x:/relea...

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

Here's a fix within Drush: https://github.com/drush-ops/drush/pull/237

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

I agree with moshe, #9 is a temporary solution. #12 fixes the *core* download problem but then requires all make files to then specify type=module or type=theme, which is more disruptive to existing projects.

The real fix is to get the xml fixed to its previous state.

FMB’s picture

FMB CreditAttribution: FMB commented

As I understand it, for some reason project nodes no longer reference the taxonomy vocabulary called "Projects". Could a maintainer verify which taxonomy terms are attached to his/her project?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

The issue is that project type is no longer a vocabulary, but a node type. After discussing in IRC with moshe, drumm and DamZ, I think this is the solution:

  1. Restore old xml structure immediately
  2. Announce an end of life to old xml structure (6-months or so?)
  3. Drush is updated to work with both old and new xml
tvn’s picture

tvn CreditAttribution: tvn commented
Issue tags: +Drupal.org 7.1
timaholt’s picture

timaholt CreditAttribution: timaholt commented

From my testing, even specifying type="theme" on themes is not working. Not sure if this is because of using the GET change in the core, or if D.o isn't specifying the type correctly on themes either.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

Re #17, I'm unable to reproduce this particular issue. I am seeing themes without type placed in the modules folder, but once specifying, for instance, projects[adaptivetheme][type] = "theme", the theme is placed in the proper place.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Assigned: Unassigned » drumm
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Project: [Archive] Drupal.org D7 upgrade QA » Project
Version: » 7.x-2.x-dev
Component: Code » Releases
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Active » Fixed

I committed and deployed a fix for this, http://drupalcode.org/project/project.git/commit/e0d3e45. An entire run of updating all the feeds will take 4 hours. drupal, bad_judgement, boxes, admin, and zen have been already been updated for verification.

(Ideally, we would have converted the whole thing to SimpleXML and run it through an alter process to let Drupalorg put it's specific info in, but that can be a separate issue.)

iLoreto’s picture

iLoreto CreditAttribution: iLoreto commented

Mr. Drumm, Thank you very much for your code commit!
There was a lot of stress in the office because of this nomenclature issue...but such is the way of dependencies.
I commend you for your agile skill!
Some folk do not understand the power of drush, I'm glad you do.
Godspeed.

AlfTheCat’s picture

AlfTheCat CreditAttribution: AlfTheCat commented

On my end drush make is still not working atm. It's able to retreive Drupal core, but not contrib.
Any guidance as to when it should be working again?

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Fixed » Needs work

Project terms are being added to each release. We need them at the top level of the xml (where "Maintenance status" and "Development status").

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs work » Needs review
FileSize
project-2126123-project_type_in_release_history.patch3.49 KB
boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented

The fix from comment #21 works for me on my pc - using drush 6.0.0.
But it still had an issue to deploy my project on a client's aegir setup which uses much more older version of drush (4.6).
In order to fix the problem a put the type attribute for all the modules, themes, profiles and libraries and it works fine now.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Committed another fix to cover #24. http://drupalcode.org/project/project.git/commit/ed3185201feb2d7c7f5ea13...

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Deployed. The XML feeds are rebuilding.

fuzzy76’s picture

fuzzy76 CreditAttribution: fuzzy76 commented

Deprecating in 6 months would probably create a lot of problems. AFAIK current Aegir does not support newer Drush versions, so anyone on Aegir is unable to upgrade.

AlfTheCat’s picture

AlfTheCat CreditAttribution: AlfTheCat commented

@fuzzy76
Exactly, this is the issue I'm running into. Aegir 2.x supports drush versions of 5.x and up. Aegir 1.x, the currents stable branch, does not. 4.5 is recommended there.
I've been trying to deploy a new instance of Aegir, which fails. I'm now stuck in the middle of a server migration...

boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented

@fuzzy76, @AlfTheCat

I successfully managed to modify my make files to work with Aegir 1.x and drush 4.5. Just be sure that you have added type attributes everywhere.
- for modules use 'module'
- for themes use 'theme'
- for profiles use 'profile'
- for libraries use 'libraries'

By the way I experienced today that drupal.org was down a couple of times which also could make you profile build to fail...

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented

Thanks Neil and Damien, our build process is working again.

sylus’s picture

sylus CreditAttribution: sylus commented

I am still getting the same problems with drush make (5.8) trying to pull down Drupal.

Shouldn't the following work now?

projects[drupal][version] = 7.23
projects[drupal][type] = core

https://travis-ci.org/wet-boew/wet-boew-drupal/jobs/13507094

sylus’s picture

sylus CreditAttribution: sylus commented

Maybe was drush cache because works now for me.

JStarcher’s picture

JStarcher CreditAttribution: JStarcher commented

@sylus

See https://github.com/drush-ops/drush/issues/234#issuecomment-27780730

I had to manually clear drush cache by removing the ~/.drush/cache directory.

sylus’s picture

sylus CreditAttribution: sylus commented

I have noticed that my themes without the type=theme attribute are still not placing themselves in the right directory. Is this because it will take a while for the xml feed to generate?

mpotter’s picture

mpotter CreditAttribution: mpotter commented

In my case, even themes marked with the type=theme are not working. For example, I have this in the openatrium.make file:

projects[oa_radix][type] = theme
projects[oa_radix][version] = 2.0

and when drupal.org packaged the profile, the oa_radix theme was put within profiles/openatrium/modules rather than profiles/openatrium/themes

So this is still causing install profiles to break. Not sure how it's related to the original problem or not since specifying the type shouldn't be relying on anything in the xml feed. But there is still a serious regression issue here that needs to be fixed (without requiring that we all update our version of drush)

Let me know if this is something I need to post back to the D7QA queue if it's an issue with the Packager.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

The rebuild is still in process. The last issues seen (like #37) are of projects that have not been rebuilt yet.

mpotter’s picture

mpotter CreditAttribution: mpotter commented

Cool, thanks for the update. Will check again in the morning.

eliza411’s picture

eliza411 CreditAttribution: eliza411 commented

Releases XML has been rebuilt on Drupal.org, and it would be ideal if some of the people following this issue could verify that the expected functionality has been restored.

eliza411’s picture

eliza411 CreditAttribution: eliza411 commented

Important: Be sure to rm -rf ~/.drush/cache before testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

Drush make tests are all passing, as are our local builds. Thanks for everybody's quick work on this!

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Fixed

Marking fixed for now.

sylus’s picture

sylus CreditAttribution: sylus commented

Seconding this as everything now works on my end.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Related issues: +#1003764: Add an alter hook invoked while generating release-history XML files

Thanks to everyone who jumped in to quickly solve this!

Re #21:

(Ideally, we would have converted the whole thing to SimpleXML and run it through an alter process to let Drupalorg put it's specific info in, but that can be a separate issue.)

That's #1003764: Add an alter hook invoked while generating release-history XML files

Cheers,
-Derek

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Stable releases are working fine now, both core and contrib.

However, dev snapshots still seem to be broken due to a md5sum mismatch, e.g. drupal-7.x-dev, try "drush dl drupal-7.x-dev".

I can open a separate bug if it's a different problem...

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

I can confirm #46 (and it isn't resolved by wiping the drush cache).

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

#46 is the old #1961304: File is corrupt (wrong md5 checksum) error issue, not a regression. That should be solved by updating the release XML per-project as a queued operation, instead of everything every 6 hours.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.