Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.wysiwyg/wysiwyg.install:138: while ($format = db_fetch_object($result)) {
wysiwyg/wysiwyg.install:143: while ($filter = db_fetch_object($result2)) {
wysiwyg/wysiwyg.install:188: while ($profile = db_fetch_object($result)) {
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | remove-old-update-functions-1855138-5.patch | 4.09 KB | Pere Orga |
Comments
Comment #1
Simon Georges CreditAttribution: Simon Georges commentedThe code you're referencing is in
wysiwyg_update_6001(), therefore it won't be executed in a D7 installation. I don't think there is anything to fix here.Comment #2
TwoDThat is true, that code would not run in D7.
Comment #3
kenorb CreditAttribution: kenorb commentedSee:
https://drupal.org/node/224333#dbtng
Comment #4
kenorb CreditAttribution: kenorb commentedSo the solution could be to remove this code completely from 7.x
Comment #5
Pere OrgaPatch attached
Comment #6
TwoDI made a few tests today and D7 does run the old updates if the module's schema number is 6xxx in the system table, implying we should have ported these functions to DBTNG as well.
However, since these functions also exist in the 6.x-2.x branch along with other update functions performing the same task as some of the 7xxx update function in the 7.x-2.x branch, and the recommendation is to upgrade to the latest minor release before upgrading to a major release; I think we should still remove them.
However, we must also implement hook_update_last_removed() to make users aware of this fact when upgrading.
I have done so, and committed this to 7.x-2.x.
Thanks for reporting and patching this!
Comment #7
TwoDCan't post a patch right now, but the commit is e4a4d9d