Any page moderated by mollom (like the ones where users can post comments) now fails to validate as XHTML 1.0 strict. The reason for this is the autocomplete attribute which is served to many non-human useragents including the w3c validator that uses the referer: http://validator.w3.org/check/referer

I know that this attribute is part of a spam trap and plays an important role there, but if something else is possible, can you look into alternatives to this non-standard attribute? https://wiki.mozilla.org/The_autocomplete_attribute_and_web_documents_us...

It's a shame that this is the only validation error on many mollom-using Drupal sites so when you have time, I'd be really happy if you could revise the spam trap or allow one to add "trusted sites" that don't get served the spam trap.

Related issues

CommentFileSizeAuthor
#9 mollom.autocomplete.9.patch866 bytessun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scottsawyer’s picture

Yeah, I just validated my page, 1 error, autocomplete on mollom.

Maybe there is a way to over-ride in the theme? Or a module? I'd hate to hack this module.

Zoltán Balogh’s picture

Priority: Minor » Normal

On my pages too (7.x), subscribe.

sun’s picture

Title: Improper autocomplete attribute » autocomplete="off" attribute breaks XHTML validation
Version: 6.x-1.x-dev » 7.x-2.x-dev
Component: Code » User interface
edulterado’s picture

The same case here (7.x). Is there a workaround for this?

mzgajner’s picture

Another victim chiming in, using 7.x.

dan_aka_jack’s picture

Title: autocomplete="off" attribute breaks XHTML validation » autocomplete="off" attribute breaks XHTML validation which breaks posting to Google+

I'm seeing this same issue.

This validation failure has a rather inconvenient side effect: It seems that the failure to produce valid XHTML prevents Drupal links from being shared on Google Plus. To be more specific:

If I set Mollom's "protection mode" to "CAPTCHA" on my site then XHTML validation fails and, if I try to post a link to my site from Google Plus, Google Plus fails to load my website and complains that it "Could not load website".

In order to post my blogs to Google Plus, I need to first set "protection mode" to "text analysis".
My site validates correctly if Mollom's protection mode is set to "text analysis" rather than "CAPTCHA".

However, I'd much prefer to use CAPTCHA rather than text analysis so I always switch Mollom's protection mode to CAPTCHA after successfully posting to Google+.

sun’s picture

Title: autocomplete="off" attribute breaks XHTML validation which breaks posting to Google+ » autocomplete="off" attribute breaks XHTML validation

@dan_aka_jack: That must be a different issue, because the form element containing the autocomplete="off" attribute is generated for all protection modes; i.e., regardless of whether the form is protected by text analysis or CAPTCHA.

@all:

In times of HTML5, and encountering a general move of web designers/developers to ignore overly strict XHTML spec validation failures, I'm not really sure whether there is anyone who cares enough to work on this issue... But if you do, feel free propose a patch. :)

sun’s picture

Q: Would you guys generally install the Elements module when doing a HTML5 site in D7 or D6?

(We could possibly add a unique condition before adding the attribute.)

sun’s picture

Issue summary: View changes

Updated issue summary.

sun’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
866 bytes

Does attached patch help in any way?

It only changes one of the two elements that are using the autocomplete="off" attribute (the one for the CAPTCHA).
(Removing it from the honeypot element would have negative consequences.)

sun’s picture

Any feedback?

I don't know how to test whether the reported issue still occurs with the patch in #9, so any help would be appreciated.

eshta’s picture

I've heard other's say that this works for them. Not sure if its the best approach for this but it's an option for those searching.
https://wiki.mozilla.org/The_autocomplete_attribute_and_web_documents_us...

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd" [
<!ATTLIST form autocomplete CDATA #IMPLIED>
]>
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
eshta’s picture

Status: Needs review » Postponed (maintainer needs more info)
Nick_vh’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)