Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This may not be so important in the long term since we are removing all of this code, but it's one less thing to have sitting around in menu.inc
There is a hunk in menu_router_build() that replaces the hook_menu path with the one from the route. If we just make them match we don't have to!
This needs #2102125: Big Local Task Conversion to fix the block demo path.
Comment | File | Size | Author |
---|---|---|---|
#9 | menu-2107039-9.patch | 39.83 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettUploading a couple different approaches to see what breaks and why.
Comment #2
tim.plunkettStill blocked by #1954892: Replace 'theme callback' and hook_custom_theme() with a clean theme negotiation system
Comment #4
tim.plunkettTheme callback went in.
Comment #6
tim.plunkettMENU_DEFAULT_LOCAL_TASKS mean we still need some of this.
Comment #8
tim.plunkettThis should fix it. And removes a lot of code in the meantime.
Comment #9
tim.plunkettUgh, bad copy/paste
Comment #11
tim.plunkett9: menu-2107039-9.patch queued for re-testing.
Comment #13
tim.plunkettOh I forgot #1954892: Replace 'theme callback' and hook_custom_theme() with a clean theme negotiation system got reverted.
Comment #14
dawehnerThis basically touches a lot of similar lines to https://drupal.org/node/2047633 .
Comment #15
tim.plunkettYeah I'll just leave this postponed until all of that is done. This is not urgent, just cleanup.
Comment #16
amateescu CreditAttribution: amateescu commentedI think #2177041: Remove all implementations of hook_menu makes this issue obsolete.