[D7] Share Send Save Integration

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdcampos2141293git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi dcampos,
According to the pareview.sh, there are quite a lot of errors and warnings needs to be fixed.
Refer http://pareview.sh/pareview/httpgitdrupalorgsandboxdcampos2141293git for the errors and warnings log. These needs to be fixed.

Manual Reviews.
I have installed the module in a fresh drupal site,

• I was not able to find the link to the module configuration page on the "admin/config" page, but was able to access through url "admin/config/sharesendsave".
• When I check the configuration page, the form is pre-filled and when I save the form, the form saved message is displayed. If I enable a Share Send Save Block, the block is enabled, but the there is no content displayed in the block rendered.
• You have not defined the variables prefixed with your module's name to avoid name collisions with others.
• There was no proper instructions to the user after the installation of the module and also after saving the module settings form.

Please fix the above reviews and I think the module needs a proper testing from your end.

Use coder module and perform code review and fix formatting issues.

Manual Reveiw:

Readme.txt

• Create a install/configure help document. Refer https://drupal.org/node/161085.

share_send_save_integration.info

• Specify configuration path for your module, so users can easily navigate to configuration section after installation. Refer https://drupal.org/node/1111212.

  configure = admin/config/sharesendsave

share_send_save_integration.module

• Include a help hook. Refer https://drupal.org/node/161085.
• Specify the menu type in your menu hook to list the configuration link in configuration page (admin/config). Refer https://api.drupal.org/api/drupal/modules!system!system.api.php/function/hook_menu/7.

includes/form.admin.inc

• Why not use system_settings_form

Replace

/**
 * Implements hook_form().
 */
function share_send_save_integration_admin_settings($form, &$form_state) {
  $form['settings']['sharesendsave_integration_title'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Title'),
    '#default_value' => variable_get('sharesendsave_integration_title', 'Title'),
    '#description' => t('Add the title of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['settings']['sharesendsave_integration_url'] = array(
    '#type' => 'textfield',
    '#title' => t('Site root URL'),
    '#default_value' => variable_get('sharesendsave_integration_url', 'http://ssshare.it/dyuq'),
    '#description' => t('Add the URL of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['settings']['sharesendsave_integration_image'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Image'),
    '#default_value' => variable_get('sharesendsave_integration_image', 'http://www.xalkori.com/images/Xalkori_FB_Lung.jpg'),
    '#description' => t('Add the image of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );

  $form['settings']['sharesendsave_integration_fbapp_id'] = array(
    '#type' => 'textfield',
    '#title' => t('Facebook ID'),
    '#default_value' => variable_get('sharesendsave_integration_fbapp_id', '517540621591012'),
    '#description' => t('Add the Facebook ID of your website to link it with Facebook.'),
    '#maxlength' => 255,
  );

  $form['settings']['sharesendsave_integration_type'] = array(
    '#type' => 'textfield',
    '#title' => t('Site type'),
    '#default_value' => variable_get('sharesendsave_integration_type', 'Website'),
    '#description' => t('Add the type of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );

  $form['settings']['sharesendsave_integration_site_name'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Name'),
    '#default_value' => variable_get('sharesendsave_integration_site_name', 'xalkori.com'),
    '#description' => t('Add the name of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );

  $form['settings']['sharesendsave_integration_description'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Description'),
    '#default_value' => variable_get('sharesendsave_integration_description', 'Description'),
    '#description' => t('Add the description of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Submit'),
  );

  $form['#submit'][] = 'share_send_save_integration_admin_settings_submit';

  return $form;
}

/**
 * Implements hook_form_submit().
 */
function share_send_save_integration_admin_settings_submit($form, &$form_state) {
  variable_set('sharesendsave_integration_title', $form_state['values']['sharesendsave_integration_title']);
  variable_set('sharesendsave_integration_url', $form_state['values']['sharesendsave_integration_url']);
  variable_set('sharesendsave_integration_image', $form_state['values']['sharesendsave_integration_image']);
  variable_set('sharesendsave_integration_fbapp_id', $form_state['values']['sharesendsave_integration_fbapp_id']);
  variable_set('sharesendsave_integration_type', $form_state['values']['sharesendsave_integration_type']);
  variable_set('sharesendsave_integration_site_name', $form_state['values']['sharesendsave_integration_site_name']);
  variable_set('sharesendsave_integration_description', $form_state['values']['sharesendsave_integration_description']);

  drupal_set_message(t('Configuration saved successfully!'));
  
}

with

/**
 * Implements hook_form().
 */
function share_send_save_integration_admin_settings($form, &$form_state) {
  $form['sharesendsave_integration_title'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Title'),
    '#default_value' => variable_get('sharesendsave_integration_title', 'Title'),
    '#description' => t('Add the title of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_url'] = array(
    '#type' => 'textfield',
    '#title' => t('Site root URL'),
    '#default_value' => variable_get('sharesendsave_integration_url', 'http://ssshare.it/dyuq'),
    '#description' => t('Add the URL of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_image'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Image'),
    '#default_value' => variable_get('sharesendsave_integration_image', 'http://www.xalkori.com/images/Xalkori_FB_Lung.jpg'),
    '#description' => t('Add the image of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_fbapp_id'] = array(
    '#type' => 'textfield',
    '#title' => t('Facebook ID'),
    '#default_value' => variable_get('sharesendsave_integration_fbapp_id', '517540621591012'),
    '#description' => t('Add the Facebook ID of your website to link it with Facebook.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_type'] = array(
    '#type' => 'textfield',
    '#title' => t('Site type'),
    '#default_value' => variable_get('sharesendsave_integration_type', 'Website'),
    '#description' => t('Add the type of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_site_name'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Name'),
    '#default_value' => variable_get('sharesendsave_integration_site_name', 'xalkori.com'),
    '#description' => t('Add the name of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  $form['sharesendsave_integration_description'] = array(
    '#type' => 'textfield',
    '#title' => t('Site Description'),
    '#default_value' => variable_get('sharesendsave_integration_description', 'Description'),
    '#description' => t('Add the description of your website that will appear for social media share.'),
    '#maxlength' => 255,
  );
  
  return system_settings_form($form);
}

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.