Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
locale.settings.yml
locale.config.de.locale_test.translation.yml
locale_test.no_translation.yml
locale_test.translation.yml
locale_test_translate.info.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#5 2105969-config-update-5.patch873 bytesvijaycs85
#5 2105969-diff-3-5.txt871 bytesvijaycs85
#5 2105969-diff-3-5.txt871 bytesvijaycs85
#3 2105969-3.patch393 bytessidharthap
#1 2105969-1.patch1.51 KBsidharthap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap commented
Status: Active » Needs review
FileSize
2105969-1.patch1.51 KB

initial patch

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Needs work 
+++ b/core/modules/locale/config/locale.settings.yml
@@ -1,14 +1,14 @@
-cache_strings: true
-translate_english: false
+cache_strings: TRUE
+translate_english: FALSE
...
-  check_disabled_modules: false
+  check_disabled_modules: FALSE
...
-  overwrite_customized: false
-  overwrite_not_customized: true
+  overwrite_customized: FALSE
+  overwrite_not_customized: TRUE
...
-  import_enabled: '1'
+  import_enabled: 1

All boolean true/false.

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap commented
Status: Needs work » Needs review
FileSize
2105969-3.patch393 bytes

Thank you @Vijaycs85

enhdless’s picture

enhdless CreditAttribution: enhdless commented
Issue summary: View changes
Status: Needs review » Needs work

one more small fix needed,

import_enabled: 1

should be 

import_enabled: true
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Make sure all YML files in Locale module has no type-casting to string. » Make sure all YML files in Locale module has no type-casting to string + update schema
Status: Needs work » Needs review
FileSize
2105969-diff-3-5.txt871 bytes
2105969-diff-3-5.txt871 bytes
2105969-config-update-5.patch873 bytes

Re-rolling with settings and schema update...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.