Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
views.view.test_dblog.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#4 drupal-2105933-4-dblog-config.patch565 bytesdsdeiz
#1 dblog_config-2105933-2.patch562 bytesa_thakur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Active » Needs review
FileSize
dblog_config-2105933-2.patch562 bytes

Made changes in following file views.view.test_dblog.yml

Changed

  status: '1'

to

  status: 1

Do not see more occurrences of int, octal or boolean in the file

enhdless’s picture

enhdless CreditAttribution: enhdless commented
Issue summary: View changes
Status: Needs review » Needs work

Instead of

status: 1

it should be

status: true
enhdless’s picture

enhdless CreditAttribution: enhdless commented
Issue tags: +Novice
dsdeiz’s picture

dsdeiz CreditAttribution: dsdeiz commented
FileSize
drupal-2105933-4-dblog-config.patch565 bytes

Patch attached.

dsdeiz’s picture

dsdeiz CreditAttribution: dsdeiz commented
Status: Needs work » Needs review
enhdless’s picture

enhdless CreditAttribution: enhdless commented
Status: Needs review » Reviewed & tested by the community

Looks great to me!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.