Follow up for #1953404: Add config schema to field and instance config entities
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in image module.
Schema in place
field.image.settings
Note: Part of main field schema patch at #1953404: Add config schema to field and instance config entities
Schema not yet in place
field.image.instance_settings
field.image.value
field_widget.image_image.settings
Comment | File | Size | Author |
---|---|---|---|
#27 | 1973436-config-schema-field-image-27.patch | 5.07 KB | claudiu.cristea |
#27 | interdiff.txt | 1.17 KB | claudiu.cristea |
#14 | 1973436-config-schema-field-image-14.patch | 4.46 KB | claudiu.cristea |
#11 | 1973436-config-schema-field-image-11.patch | 3.69 KB | vijaycs85 |
#11 | 1973436-diff-8-11.txt | 951 bytes | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch...
Comment #3
vijaycs85#1953404: Add config schema to field and instance config entities has to be committed to fix this part.
Comment #4
vijaycs85Removing image module changes from main issue and adding here...
Comment #5
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #6
claudiu.cristeaAny news here? Is this still needed?
Comment #7
claudiu.cristeaLet's rework this.
Comment #8
vijaycs85Updating with re-roll and removed widget...
Comment #9
vijaycs85Updating with re-roll and removed widget...
Comment #10
claudiu.cristeaDefault image
default_image
is no more a simple value (anyway it was wrongly casted here as 'string' and 'bool'). It has been converted to associative array in #1443606: Alt, title, width and height for default images.user_register_form
has gone along with #2049485: Remove traces of the 'user_register_form' field setting and we shouldn't reintroduce it here.Comment #11
vijaycs85Thanks for the review @claudiu.cristea. Addressing both issues in #10 and attaching verified config_inspector screenshot.
Comment #12
aspilicious CreditAttribution: aspilicious commentedBUSTED :D, needs to be a mapping
Comment #13
vijaycs85here is mapping?
Comment #14
claudiu.cristeaHere :)
Comment #15
aspilicious CreditAttribution: aspilicious commentedHmm isn't that mapping part of field.image.value ?
(so that we can reference it as image type)
Partly guessing here, not sure how config schemas relate to field defintions
Comment #16
claudiu.cristeaOk, then this looks better
Comment #19
claudiu.cristeaWrong generated patch. Here we go.
Comment #20
vijaycs85Can we make this as content type by adding in image.data_type.schema.yml with key as field_image_default
Not sure we can use type like this. We always keep content type with underscore than schema definition...
Comment #21
claudiu.cristeaComment #24
claudiu.cristeaComment #26
vijaycs85Looks good to me, except one minor suggestion...
may be field_default_image?
Comment #27
claudiu.cristeaOK :)
Comment #28
aspilicious CreditAttribution: aspilicious commentedGood to go...
Comment #29
webchickCommitted and pushed to 8.x. Thanks!