Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Background:
This issue is part of the task to update the hook_help texts of the modules for Drupal 8:
#1908570: [meta] Update or create hook_help() texts for D8 core modules
Task:
The links in hook_help need to be changed.
See https://drupal.org/node/632280#url-note
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 2.26 KB | batigolix |
#3 | hook-help-editor-2091377.3.patch | 4.41 KB | batigolix |
#1 | hook-help-editor-2091377.1.patch | 4.41 KB | batigolix |
Comments
Comment #1
batigolixpatch:
- changes url() to \Drupal::url()
- changes @token to !token
Comment #2
jhodgdonThanks! this all looks fine. Can you fix the newline in the middle of the Installing Text Editors item too? That shouldn't be there.
Also, someone needs to manually test the links to make sure they all work and go to the right pages with this change.
Comment #3
batigolixPatch removes newline
I tested the links (they work)
Comment #4
jhodgdonThanks! Let's get this quick fix in.
Comment #5
webchickMan. :( Diffs like this makes me cry a bit inside. I can confirm this is the New World Order™ though, so...
Committed and pushed to 8.x. Thanks!
Comment #6
batigolixI say this deserves a honorable mention somewhere in the D8 credits for being the smallest that went into D8. Possible?
Comment #7
jhodgdonIt is definitely not the smallest patch I've seen that got into D8 -- I'm sure at least one has just changed 1 character (spelling errors). :)