[D7] Webform Tabindex

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

FYI

@Devendra
on webform_tabindex_webform_component_update
you should use db_merge
here you are doing first select then insert/update

Remove that .swp.

In webform.tabindex.admin.inc - C style comments (/* */) is discouraged in function comments. Kindly change it to (//) for consistency.

Removed some review comment links that are not actual reviews.

Don't forget to add the "PAReview: review bonus" tag next time as indicated in http://drupal.org/node/1975228 , otherwise you won't show up on my high priority list.

manual review:

1. project page is too short. It is not clear to me what this module does or what the use case is. See https://drupal.org/node/997024
2. The Git commits are not connected to your user account. You need to specify an email address. See http://drupal.org/node/1022156 and http://drupal.org/node/1051722
3. webform_tabindex_uninstall(): uninstalling the schema is not necessary in drupal 7, so this function should be removed.
4. webform_tabindex_form_webform_component_edit_form_alter(): Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075 . Also elsewhere.
5. webform_tabindex_webform_component_delete(): no need to check for existence first, just run the delete query?
6. webform_tabindex_form(): comments in function bodies should use the "//" style, even if they are multi-line. See https://drupal.org/node/1354#inline

The unclear project page is a blocker right now, otherwise this looks mostly good to go. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

manual review:

• "$query = "SELECT tabindex FROM webform_tabindex WHERE nid = :nid AND cid = :cid";": the table name needs to be enclosed with { }, see https://drupal.org/node/310072

Otherwise this looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cubeinspire as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, devendra.yadav!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2172541

Project 2: https://drupal.org/node/2154393

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.