The documentation for search_form() says the return value is 'An HTML string containing the search form' but it actually returns a form array.

CommentFileSizeAuthor
#6 search_form_doc-926440-new-D6.patch515 bytesdaniels220
#4 search_form_doc-926440-D6.patch492 bytesdaniels220
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It would be possible to use the d7 documentation "A Form API array for the search form."

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Yes, the D7 version should be used, for consistency. Thanks for reporting.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Documentation problem with search_form » search_form doc has wrong return value information
Issue tags: +Novice

good project for a novice doc contributor

daniels220’s picture

daniels220 CreditAttribution: daniels220 commented
Status: Active » Needs review
FileSize
search_form_doc-926440-D6.patch492 bytes

Have a patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

This patch doesn't apply - badly formatted at the top with "search_old.module".

Other than that, looks good...

daniels220’s picture

daniels220 CreditAttribution: daniels220 commented
Status: Needs work » Needs review
FileSize
search_form_doc-926440-new-D6.patch515 bytes

I hope the two extra lines Git created at the top don't mess things up. New patch attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.