Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
Fix and issue patch for below config files:
custom_block.type.basic.yml
entity.view_mode.custom_block.full.yml
block.block.stark.test_block.yml
views.view.test_view_block.yml
views.view.test_view_block2.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 441 bytes | foxtrotcharlie |
#14 | 2105915-block-test-config-14.patch | 3.1 KB | foxtrotcharlie |
#12 | 2105915-block-test-config-12.patch | 3.53 KB | vijaycs85 |
#5 | 2105915-diff-3-5.txt | 2.47 KB | vijaycs85 |
#5 | 2105915-block-test-config-5.patch | 3.28 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch...
Comment #2
benjy CreditAttribution: benjy commentedNeeds a reroll.
Comment #3
foxtrotcharlie CreditAttribution: foxtrotcharlie commentedMy first reroll - hope it's right...
Comment #4
foxtrotcharlie CreditAttribution: foxtrotcharlie commentedI just noticed that in block_test_theme.info.yml and entity.view_mode.custom_block.full.yml the booleans true and false are lowercase and not uppercase. Should they be changed to uppercase? There is also a value of '-1' (in the single quotes) in block.block.test_block.yml and I wonder if it the quotes should be removed?
Comment #5
vijaycs85Fixing the conversions missed in #3
Comment #6
benjy CreditAttribution: benjy commentedIs there any reason why we're not fixing up "block.routing.yml" here as well? eg the _access_theme properties.
Comment #7
vijaycs85@benjy the meta is more about the config, routing or info aren't config.
Comment #8
benjy CreditAttribution: benjy commentedOK sounds good.
Comment #9
xjm5: 2105915-block-test-config-5.patch queued for re-testing.
Comment #10
catch5: 2105915-block-test-config-5.patch queued for re-testing.
Comment #12
vijaycs85Re-rolling...
Comment #13
benjy CreditAttribution: benjy commentedWhy is this uppercase now?
Comment #14
foxtrotcharlie CreditAttribution: foxtrotcharlie commentedI've changed the uppercase TRUE back to lowercase true. According to this comment by chx and this info in the Symfony documentation, Symfony uses lowercase for booleans.
Comment #15
vijaycs85Sorry for my mistake... +1 to RTBC.
Comment #16
benjy CreditAttribution: benjy commentedComment #17
webchickCommitted and pushed to 8.x. Thanks!