Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
custom_block.type.basic.yml
entity.view_mode.custom_block.full.yml
block.block.stark.test_block.yml
views.view.test_view_block.yml
views.view.test_view_block2.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
4.2 KB

Initial patch...

benjy’s picture

Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs a reroll.

foxtrotcharlie’s picture

Assigned: Unassigned » foxtrotcharlie
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3.24 KB

My first reroll - hope it's right...

foxtrotcharlie’s picture

I just noticed that in block_test_theme.info.yml and entity.view_mode.custom_block.full.yml the booleans true and false are lowercase and not uppercase. Should they be changed to uppercase? There is also a value of '-1' (in the single quotes) in block.block.test_block.yml and I wonder if it the quotes should be removed?

vijaycs85’s picture

Fixing the conversions missed in #3

benjy’s picture

Is there any reason why we're not fixing up "block.routing.yml" here as well? eg the _access_theme properties.

vijaycs85’s picture

@benjy the meta is more about the config, routing or info aren't config.

benjy’s picture

Status: Needs review » Reviewed & tested by the community

OK sounds good.

xjm’s picture

catch’s picture

The last submitted patch, 5: 2105915-block-test-config-5.patch, failed testing.

vijaycs85’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
3.53 KB

Re-rolling...

benjy’s picture

+++ b/core/modules/block/tests/modules/block_test/block_test.info.yml
@@ -4,4 +4,4 @@ description: 'Provides test blocks.'
+hidden: TRUE

Why is this uppercase now?

foxtrotcharlie’s picture

I've changed the uppercase TRUE back to lowercase true. According to this comment by chx and this info in the Symfony documentation, Symfony uses lowercase for booleans.

vijaycs85’s picture

Sorry for my mistake... +1 to RTBC.

benjy’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.