Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
Fix and issue patch for below config files:
entity.view_mode.node.full.yml
entity.view_mode.node.rss.yml
entity.view_mode.node.teaser.yml
node.settings.yml
system.action.node_delete_action.yml
system.action.node_make_sticky_action.yml
system.action.node_make_unsticky_action.yml
system.action.node_promote_action.yml
system.action.node_publish_action.yml
system.action.node_save_action.yml
system.action.node_unpromote_action.yml
system.action.node_unpublish_action.yml
views.view.content.yml
views.view.frontpage.yml
node_access_test_language.info.yml (tab missing in dependencies list)
node.type.default.yml
node.type.import.yml
views.view.test_contextual_links.yml
views.view.test_field_type.yml
views.view.test_filter_node_uid_revision.yml
views.view.test_node_bulk_form.yml
views.view.test_node_revision_nid.yml
views.view.test_node_revision_vid.yml
views.view.test_node_row_plugin.yml
views.view.test_node_view.yml
views.view.test_status_extra.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#6 | 2105977-node-config-cleanup-6.patch | 11.78 KB | vijaycs85 |
#3 | 2105977-2-node-yaml-variable-type.patch | 93.96 KB | alexander_danilenko |
#1 | 2105977-1-node-yaml-variable-type.patch | 44.98 KB | alexander_danilenko |
Comments
Comment #1
alexander_danilenko CreditAttribution: alexander_danilenko commentedComment #3
alexander_danilenko CreditAttribution: alexander_danilenko commentedfixed missing tab in
\node\tests\modules\node_access_test_language\node_access_test_language.info.yml:7
Comment #4
gddIs this really supposed to be the integer 1 or a boolean value? The key of 'status' implies the latter to me. I saw this a few other places as well.
In other conversion I've seen we use lowercase false instead of uppercase, we should figure out what we want to standardize on.
Comment #5
gddAlso there are some weird characters at the top of this patch which is causing it to fail when I try to apply it with git. When I try to less it, it thinks that it is a binary file. Could you reroll?
Comment #6
vijaycs85Reroll...
Comment #7
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.
Comment #8
vijaycs85