Background:
This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules

Tasks:
- review / write the hook_help text according to help guidelines

CommentFileSizeAuthor
#7 interdiff.txt802 bytesbatigolix
#7 update-hook-help-forum-2091455-7.patch3.59 KBbatigolix
#6 interdiff-2091455-2-6.txt2.1 KBInternetDevels
#6 update-hook-help-forum-2091455-6.patch3.58 KBInternetDevels
#2 forum-updated_help_d8-2091455-2.patch3.52 KBberkas1
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

berkas1’s picture

berkas1 CreditAttribution: berkas1 commented

Taking it - Drupalcon Prague

berkas1’s picture

berkas1 CreditAttribution: berkas1 commented
Status: Active » Needs review
FileSize
forum-updated_help_d8-2091455-2.patch3.52 KB
petrpo’s picture

petrpo CreditAttribution: petrpo commented

Manualy patched module forum and all links are working right.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks for the patch and the testing!

Looking over this help as a whole, it doesn't really follow our guidelines on http://drupal.org/node/632280 , so the help for this module needs some more work.

a) The "For more information..." line is not our standard wording/format.

b) The Uses topics should all have headers with -ing verbs.

Other than that, I think it looks good.

berkas1’s picture

berkas1 CreditAttribution: berkas1 commented
Assigned: Unassigned » berkas1

Thanks, I'll send patch ASAP

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #1908570: [meta] Update or create hook_help() texts for D8 core modules
FileSize
update-hook-help-forum-2091455-6.patch3.58 KB
interdiff-2091455-2-6.txt2.1 KB

Added patch.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix commented
FileSize
update-hook-help-forum-2091455-7.patch3.59 KB
interdiff.txt802 bytes

I verified the patch in #6:

- Verify that all the links work --> Okay
- Verify that all mentions of pages/text within the UI match what is seen in the UI --> Okay
- Verify that the formatting is OK. --> Okay

I just found the link to d.o should be https. Attached patch fixes that

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix commented
Assigned: berkas1 » Unassigned
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks like this one is ready to commit! We're in the middle of a "only commit critical and major issues" week, so I'll get it committed on the 23rd or so.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

I'm being extra careful about commit conflicts lately, and there is an issue tagged "avoid commit conflicts" that touches this file. So I plan to wait to commit this until
#1996238: Replace hook_library_info() by *.libraries.yml file
is resolved. Sorry for the delay!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

#1996238: Replace hook_library_info() by *.libraries.yml file is postponed. Committed d78587e and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.