Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
After going into the IPE on a panel node and clicking "Cancel", the contextual links for the panes no longer work (seems javascript-related). Other contextual links on the page still work normally.
Comments
Comment #1
floretan CreditAttribution: floretan commentedWhen the "Cancel" or "Save" button is pressed, the panes are rebuilt using ajax. The problem with the contextual links is that they use a "destination" parameter to point back to the current page, but that in this case the "current page" is the ajax callback and not the page where the pane has been inserted.
Comment #2
mcarbone CreditAttribution: mcarbone commentedConfirmed on dev. An easy way to reproduce in a sandbox is to simply add the "Who's Online" block and even before saving the contextual "Configure Block" link has the ajax callback as the destination parameter.
Comment #3
David_Rothstein CreditAttribution: David_Rothstein commentedIt actually sounds like there are two different bugs being reported here:
Both bugs happen for more than just contextual links, although contextual links are the easiest way to experience them.
The attached patch deals with #2. It's a pretty complicated bug, so I tried to explain in the inline code comments what I think is going on.
Perhaps we should split #1 to a different issue. (See also: some of the comments at #1520492: Saving a change in the IPE results in a blank page, fine after refresh, no error.)
Comment #4
David_Rothstein CreditAttribution: David_Rothstein commentedActually, slight correction: it's not just newly-added panes, but also occurs for any pane, provided you just clicked the "Save" button.
So the main difference between the two bugs reported here is that one happens on save/add, and the other happens on cancel.
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commentedUnfortunately, changes made recently make this patch not apply. Can i get a reroll?
Comment #6
ordermind CreditAttribution: ordermind commentedI just checked the latest dev, the problem seems to have been resolved elsewhere so I'm closing this.
Comment #7
ordermind CreditAttribution: ordermind commentedMy mistake, a related issue was fixed but not this one. Contextual links still don't work after clicking "Cancel".
Comment #8
David_Rothstein CreditAttribution: David_Rothstein commentedYup, this still occurs. Let me see if it's possible to do a quick reroll to get the patch working again.
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedAlright, the reroll was pretty trivial, and testing against the latest 7.x-3.x-dev it seems to work for me.
Comment #10
tim.plunkettJust experienced the same problem, the patch works great and the added documentation is impeccable.
Comment #11
gmclelland CreditAttribution: gmclelland commentedI can confirm that the patch in #9 worked for me.
Comment #12
japerryConfirmed issue, tested patch. committed.
http://drupalcode.org/project/panels.git/commit/ed2063d
Comment #13
gmclelland CreditAttribution: gmclelland commentedAwesome!
http://www.ign.com/videos/2013/02/20/the-empire-strikes-out-clip-darth-m...
:)
Comment #14
japerryI had to revert this issue because of errors in Firefox. When this patch is applied, in some cases it can cause the browser to grind to a halt.
Revert here: http://drupalcode.org/project/panels.git/commit/c88c0aa
You can easily reproduce this with a stock commons install and this patch. Just click the IPE, click around inside panels a bit, and click cancel. You'll see the IPE menu disappears and firefox will become very slow.
Comment #16
rafenden CreditAttribution: rafenden commentedJust tested Panels with revision ed2063d46b61502707cf09c976a93cf1ef938412 and they worked well in Firefox 35.0.1.
Comment #17
milodescRe-rolled for Panels 3.6.
Comment #18
awakash CreditAttribution: awakash commentedUpdated this patch for Panels 7.x-3.7
Comment #19
joelstein CreditAttribution: joelstein as a volunteer commentedThe patch in #18 works for me. I also tested with Firefox 42, 47, and 49.0.2, which worked with no problems. I haven't tested Firefox with Commons, per #14.
Comment #20
joelstein CreditAttribution: joelstein as a volunteer commentedUpdated patch to apply cleanly with new Panels release.