The wrong usage of the hook_requirements() in aes.install produces the above error.

The patch fix this error.

The attached aes.install module file corresponds to the contents of the patch file.

The patch makes a little bit more

  • Better message logic on the status report page.
  • Corrections to the code, according to Drupal's code/style guide.
  • New code comments and exists according Drupal's doxygen guide.

Further module development

Please use the Coder module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quiptime’s picture

FileSize
4.57 KB
7.94 KB

Sorry, wrong files attached.

Please use the newly posted files.

quiptime’s picture

I think it is important

  • to fix the undefined index error
  • to improve the usability for the requirement check result display
quiptime’s picture

I think it is a good idea to fix this bug before you commit the upcoming 7.x-1.6 release.

greggles’s picture

Title: Module produce error "Undefined index: value in theme_status_report()" - patch » Module produce error "Undefined index: value in theme_status_report()"
Status: Active » Needs review

If you have a patch you can say "needs review" as the status.

eiriksm’s picture

Status: Needs review » Reviewed & tested by the community

Also found this issue, should absolutely get commited as this bug always creates an error on status pages. Wrote a patch that i was planning to post here, but this is even cleaner.

Tested and fixes the issue!

Only thing I can think of is get coding standards commited in a separate patch, but that would be up to the maintainer to consider.

dpovshed’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@quiptime, I am aware the module needs to be a fully reformatted according to coding standards, and we have a separate issue for that. Could you please do not reformat whole file - it makes difficult to review the changes?

I'd appreciate if you can fix only the issue you have in the node title - with theme_status_report(), if this is still actual. If it is already solved in some way in recent version, could we close the issuue? Thanks!

dpovshed’s picture

Status: Needs work » Closed (won't fix)

Closing as it seems obsolete and abandoned by topicstarter.

Feel free to reopen with detailed info is this is still actual for someone.