Youtube Embed Code already provides a way to autoload captions and even set default caption language. We should provide support to activate this feature.

CommentFileSizeAuthor
#10 1990660-caption-support-10.patch2.7 KBhelior
#7 media_youtube-caption_support-1990660-4.patch3.39 KBGDrupal
#6 media_youtube-caption_support-1990660-3.patch4.52 KBGDrupal
#4 media_youtube-caption_support-1990660-2.patch3.38 KBGDrupal
#1 media_youtube-caption_support-1990660-1.patch3.3 KBGDrupal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GDrupal’s picture

GDrupal CreditAttribution: GDrupal commented
Status: Active » Needs review
FileSize
media_youtube-caption_support-1990660-1.patch3.3 KB

Patch provided enables captions support with the option to set current system language as default caption too.

helior’s picture

helior CreditAttribution: helior commented
Status: Needs work » Needs review

This is really handy!

I'd replace using LANGUAGE_TYPE_INTERFACE and the $GLOBALS variable directly with this:

global $language;
$query['cc_lang_pref'] = $language->language;

And also check against accidentally using an 'und' language.

This patch certainly does the trick though, thank you.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar commented
Status: Needs review » Needs work

Would be nice to have one or two line of comment to explain what is doing this new code.

GDrupal’s picture

GDrupal CreditAttribution: GDrupal commented
FileSize
media_youtube-caption_support-1990660-2.patch3.38 KB

Moving to more consistent 

global $language;

+ typo fix + explanatory comments.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar commented

You could use LANGUAGE_NONE http://api.drupal.org/api/drupal/includes%21bootstrap.inc/constant/LANGU...

GDrupal’s picture

GDrupal CreditAttribution: GDrupal commented
FileSize
media_youtube-caption_support-1990660-3.patch4.52 KB

@dagmar Done!

GDrupal’s picture

GDrupal CreditAttribution: GDrupal commented
FileSize
media_youtube-caption_support-1990660-4.patch3.39 KB

Sorry moving to a single commit...

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar commented
Status: Needs review » Reviewed & tested by the community

Thanks!

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented

Patch looks good, tested and it works as expected. +1 on RTBC

helior’s picture

helior CreditAttribution: helior commented
FileSize
1990660-caption-support-10.patch2.7 KB

Re-rolling dagmar's changes while fixing some merge conflicts.

aaron’s picture

aaron CreditAttribution: aaron commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/media_youtube.git/commit/3f8781b.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.