Add drupal_static_fast to _views_fetch_data() [#2119369]

_views_fetch_data() can be invoked many times. I suggest to use drupal_static_fast pattern for it.

Comment	File	Size	Author
#3	views-fetch_data_fast_cache-2119369-3.patch	1.02 KB	Andrew Answer
#3	7.x-3.x: PHP 7.1 & MySQL 5.5, D7 232 pass
	views-fetch_data_fast_cache.patch	1.04 KB	maximpodorov

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

maximpodorov CreditAttribution: maximpodorov commented 24 February 2014 at 09:23

Issue summary:

View changes

Any plans to accept this?

Comment #2

Chris Matthews CreditAttribution: Chris Matthews commented 15 January 2019 at 04:51

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

File	Size
views-fetch_data_fast_cache.patch	1.04 KB

The 5 year old patch to cache.inc does not apply to the latest views 7.x-3.x-dev.

Checking patch includes/cache.inc...
error: while searching for:
 *   One example is views_get_handler.
 */
function _views_fetch_data($table = NULL, $move = TRUE, $reset = FALSE) {
  $cache = &drupal_static(__FUNCTION__ . '_cache');
  $recursion_protection = &drupal_static(__FUNCTION__ . '_recursion_protected');
  $fully_loaded = &drupal_static(__FUNCTION__ . '_fully_loaded');
  if ($reset) {
    $cache = NULL;
    $fully_loaded = FALSE;

error: patch failed: includes/cache.inc:13
error: includes/cache.inc: patch does not apply