Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Query variables set incorrectly for ip_login_no_cache creating redirect loop
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | ip-login-redirect-loop-2204743-7.patch | 701 bytes | t-lo |
| #5 | ip-login-redirect-loop-2204743-5.patch | 86.38 KB | t-lo |
| #2 | ip-login-redirect-loop-2204743-2.patch | 86.38 KB | t-lo |
Comments
Comment #1
t-lo$url = url($url, array('query' => array('ip_login_no_cache=' . md5(time())), 'absolute' => TRUE));Should be:
$url = url($url, array('query' => array('ip_login_no_cache' => md5(time())), 'absolute' => TRUE));Comment #2
t-loLatest dev version is different but still incorrect:
$url = url($url, array('query' => 'ip_login_no_cache='.md5(time()), 'absolute' => TRUE));Should be:
$url = url($url, array('query' => array('ip_login_no_cache' => md5(time())), 'absolute' => TRUE));Comment #3
t-loComment #5
t-loComment #7
t-lowas checking out the master branch, hopefully this one will pass :)
Comment #8
markpavlitski commentedThe patch definitely fixes the redirect loop issue, however there can still be cache collisions if there are multiple requests arriving within 1 second.
I'd suggest using something which is session specific, like
drupal_get_token()instead ofmd5(time()).Comment #9
davidwhthomas commentedAdjusted patch committed, thanks!