Currently collapsed fieldsets are hard to discover as they have no indicator of any kind, they are just a grey box. This normally looks ok, but when used in a more complex form they become even harder to find and use. Adding in some level of icon / arrow to better indicate there is an available interaction would improve the usability.

CommentFileSizeAuthor
#6 1782512-rubik-collapsible-fieldset-icon-06.patch1.54 KBhaydeniv
#3 rubik-collapsible-fieldset-icon-1782512-3.patch1.96 KBwbobeirne
#1 rubik-collapsible-fieldset-icon-1782512-1.patch1.97 KBwbobeirne
#1 bleeds.png6.04 KBwbobeirne
Screen Shot 2012-09-12 at 11.51.31 AM.png8.66 KBjec006
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wbobeirne’s picture

wbobeirne CreditAttribution: wbobeirne commented
FileSize
bleeds.png6.04 KB
rubik-collapsible-fieldset-icon-1782512-1.patch1.97 KB

Looks like there was already some existing code for this, I just fixed it up and re-themed it a bit. Let me know if I stepped on the toes of some functionality I was not aware of. Attached is a patch that should give the following output:

http://cl.ly/image/0P2O0f2M0K1u

The images were just a quick placeholder I whipped up. Someone feel free to replace them. Also, I'm not sure how you're supposed to include images in a patch file, so attached is the revised bleeds.png with those placeholders.

wbobeirne’s picture

wbobeirne CreditAttribution: wbobeirne commented
Status: Active » Needs review
wbobeirne’s picture

wbobeirne CreditAttribution: wbobeirne commented
FileSize
rubik-collapsible-fieldset-icon-1782512-3.patch1.96 KB

My apologies, the previous patch included a dpm. Attached is a DPMless patch.

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Status: Needs review » Needs work

This does not apply anymore. Please re-roll and I'll get it committed. Thanks!

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Good idea. Patch #3 works great for my Rubik 7.x-4.0-beta8. Please commit it.

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Issue summary: View changes
FileSize
1782512-rubik-collapsible-fieldset-icon-06.patch1.54 KB

This was partially fixed with #1389704: Icons for collapsible nested fieldsets always hidden

I like how this one works better though with the layout of the icon.

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Category: Feature request » Bug report
Status: Needs work » Needs review

Correct status.

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Status: Needs review » Fixed

committed: e624bca

I really like how this feels on the fieldsets.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

donquixote’s picture

donquixote CreditAttribution: donquixote commented
Status: Closed (fixed) » Needs work

Regression:

-.form-wrapper .form-item,
-.form-wrapper .form-wrapper {
-  border:0;
-  margin-bottom:0;
-  }

This change causes the Views UI to look weird, with duplicate borders.
The original purpose of this CSS was that nested form-wrapper elements don't have their borders pile up.
(Maybe .form-wrapper > .form-wrapper would be safer)

admin/structure/views/view/*/edit/* looks weird now. And probably some other places too.

kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored commented
Status: Needs work » Closed (fixed)

I'm pretty sure that #10 was fixed in #1388114: Views admin styles for Rubik.