I needed a div, so i just added it to the module code:

 427         '#options' => array('h2' => t('Header 2'), 'h3' => t('Header 3'), 'div' => t('Div')),

But why not even have a text field for that wrapper, so it can be set to anything?

CommentFileSizeAuthor
#17 field_group_allow-tags-in-div-field-groups_2011706-17.patch854 byteskarenann
#15 field_group_allow-tags-in-div-field-groups_2011706-15.patch854 byteskarenann
#9 field_group-div_instance_settings_text-20117060-9.patch870 byteskarenann
#3 2011706-allow-other-tags-for-fieldgroup-divs.patch805 bytesjpstrikesback
#1 field_group-missing_label_element-2011706.patch915 bytessirtet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sirtet’s picture

sirtet
Primary language German
Location Switzerland
CreditAttribution: sirtet commented
FileSize
field_group-missing_label_element-2011706.patch915 bytes

here's the patch that adds a Div to the list:

sirtet’s picture

sirtet
Primary language German
Location Switzerland
CreditAttribution: sirtet commented

also, the label element can not be changed by code currently, no theme- or preprocess alters are possible.

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented
FileSize
2011706-allow-other-tags-for-fieldgroup-divs.patch805 bytes

Thanks sirtet!!

Here it is as a textfield, next up would be to be able to add a label class but we don't have that now anyways...

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented

double post

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented
Status: Needs work » Needs review

#3: 2011706-allow-other-tags-for-fieldgroup-divs.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

typo

karenann’s picture

karenann CreditAttribution: karenann commented
Issue summary: View changes
FileSize
field_group-div_instance_settings_text-20117060-9.patch870 bytes
jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented
Status: Needs work » Needs review

Fire up the bot

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented
Version: 7.x-1.1 » 7.x-1.x-dev

Status: Needs review » Needs work

The last submitted patch, 9: field_group-div_instance_settings_text-20117060-9.patch, failed testing.

jpstrikesback’s picture

jpstrikesback CreditAttribution: jpstrikesback commented

3: 2011706-allow-other-tags-for-fieldgroup-divs.patch queued for re-testing.

The last submitted patch, 3: 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

karenann’s picture

karenann CreditAttribution: karenann commented
Status: Needs work » Needs review
FileSize
field_group_allow-tags-in-div-field-groups_2011706-15.patch854 bytes

Giving this another shot.

surgeonbor’s picture

surgeonbor CreditAttribution: surgeonbor commented

#15 works for me, but in the #description, &rt; needs to be changed to & gt ;

karenann’s picture

karenann CreditAttribution: karenann as a volunteer commented
FileSize
field_group_allow-tags-in-div-field-groups_2011706-17.patch854 bytes
Christopher Riley’s picture

Christopher Riley CreditAttribution: Christopher Riley commented

It would be great if this was committed so we had more options without a custom module or patch.

tisteegz’s picture

tisteegz CreditAttribution: tisteegz commented

Any chance of this going into a release? It is kind of frustrating to only be able to choose H2 or H3.

EDIT: I am now just using html element instead of div which allows you to choose the label element.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The 3 year old patch in #17 to field_group.module applied cleanly to the latest field_group 7.x-1.x-dev and works good for me as well so changing the status to RTBC.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

Confirming RTBC for #17. I thought about a more defensive approach with listing all elements that make sense in this case. For example this can be seen in Fences module (fences.fences.inc) but well. The input is more flexible.

Are there any security concerns?

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Title: allow other tags than h2 and h3 for DIV-fieldgroups » Allow other tags than h2 and h3 for DIV-fieldgroups

Any chance to commit this?