Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here's one to fix the duplicate package names caused by jQuery Update and Extlink, both of which are in the
package = User Interface
But extlink.module calls itself "User interface", thereby creating a second identical fieldset on the admin/build/modules page. I also added a newline at the end of the file, so the CVS packaging script would have some visual breathing space.
Comment | File | Size | Author |
---|---|---|---|
extlink_package_capitalization.patch | 551 bytes | Senpai |
Comments
Comment #1
Senpai CreditAttribution: Senpai commentedComment #2
sun+1
Comment #3
quicksketchYeah sorry I'm delaying on this patch, it is totally minor, but really those *other modules* are using the wrong package name. Like other strings in Drupal (menu titles, form labels), package names should only include the first letter capitalized. So "User Interface" is incorrect, it should be "User interface". Should we take this to other modules or just say hose-it and go against convention?
Comment #4
sunWell, UI is the abbreviation for User Interface - in this case, I thought the term was a proper noun and it would make sense to capitalize the second word, too, and changed it in jQuery Update 2.x accordingly.
Comment #5
apadernoAcronyms may be written in upper case letter, but the words which create such acronyms are written in capital case only if it refers to some association, agency, or similar.
It's correct to write UI, but we should write user interface; it's correct to write USA, as it's correct to write United States of America.
In short, following also the conventions used in Drupal, the name of the module package should be written "User interface". Said that, there is also to report that there are more modules that use "User Interface" than "User interface".
Comment #6
apadernoI would not insert user interface between the proper nouns; the right definition for proper noun is:
The week day names are also written with the initial capital letters, and so the months names.
Comment #7
sunOk. So let's start a joined effort by moving this task into all project issue queues; moving to the next, each time the package name has been fixed in the current project.
Proposing to move for two reasons: First of all, we can all push this very same issue, and secondly, other maintainers can read back then. I know that there are already existing issues in other queues suggesting the very same change - however, all maintainers will stop thinking about this, if we move the issue around.
I have commit access to
jQuery Update
jQuery UI
jQuery Lightbox
Wysiwyg API
(maybe more that might be affected, but I'm not aware of now) and committed this change using the following commit message and changelog entry now:
@maintainers: Please do not change the issue status, this issue will be moved to the next project, so just report back that you're done.
Comment #8
quicksketchThanks sun!
Comment #9
sunheh... was that a confirmation that you changed the package name in all branches of extlink?
Comment #10
sunmeh, stupid me - External Links already uses the proper package name.
Moving over to next project.
@maintainer: Any other module under your hood may need to be updated, too. Please report back which projects/branches have been fixed.
Comment #11
sunbump
Comment #12
sunIt seems like Mike Smullin is unavailable currently. Moving to next queue.
(btw: using http://drupal.org/project/issues?text=%22User%20interface%22&states=1,16... as reference, which claims that jQuery Impromptu and jQuery plugins are the last two modules -- bonus points for finding other candidates! 8)
Comment #13
mfbThanks, fixed in jquery_plugin 5.x and 6.x branches.
Comment #14
mfbHere's a list of affected modules in CVS HEAD:
activeedit/activeedit_theme_assist/activeedit_theme_assist.info:package = User Interface
activeedit/activeedit.info:package = User Interface
activemenu/activemenu.info:package = User Interface
block_refresh/block_refresh.info:package = User Interface
collapsiblock/collapsiblock.info:package = User Interface
editarea/editarea.info:package = User Interface
flir/flir.info:package = User Interface
hoverintent/hoverintent.info:package = User Interface
interface_sortable/interface_sortable_demos.info:package = User Interface
interface_sortable/interface_sortable.info:package = User Interface
jcarousel/jcarousel.info:package = User Interface
jcarousellite/jcarousellite.info:package = User Interface
jmedia/jmedia.info:package = User Interface
jq/contributions/jq_bridge/jq_bridge.info:package = User Interface
jq/jq.info:package = User Interface
jqmodal/jqmodal.info:package = User Interface
jquery_blockui/jquery_blockui.info:package = User Interface
jquery_calendar/jquery_calendar.info:package = "User Interface"
jquery_cookie/jquery_cookie.info:package = "User Interface"
jquery_fontsizer/jquery_fontsizer.info:package = "User Interface"
jquery_form/jquery_form.info:package = User Interface
jquery_heartbeat/jquery_heartbeat.info:package = "User Interface"
jquery_impromptu/jquery_impromptu.info:package = User Interface
jquery_media/jquery_media.info:package = User Interface
jquery_popupwindow/jquery_popupwindow.info:package = User Interface
jquery_treeview/jquery_treeview.info:package = "User Interface"
jquib/jquib.info:package = User Interface
jstools/jstools.info:package = User Interface
magnifier/magnifier.info:package = User Interface
nodecarousel/nodecarousel.info:package = User Interface
path_en/path_en.info:package = User Interface
quick_admin_menu/qam.info:package = User Interface
saveguard/saveguard.info:package = User Interface
swfaddress/swfaddress.info:package = "User Interface"
sys_en/sys_en.info:package = User Interface
tabs/docs/tabsexample.info:package = User Interface
tabs/tabs.info:package = User Interface
them_en/them_en.info:package = User Interface
user_en/user_en.info:package = User Interface
useren/useren.info:package = User Interface
Comment #15
sunah well... LOL
So let's iterate over this list ;)
Comment #16
sun@nedjo: Please come back to this issue when time permits; you seem to have commit access to some of the modules mentioned in #14.
Moving over to next project.
Comment #17
sunI just found out that I have CVS access to JavaScript tools - so I fixed this one. ;)
Aaron does not respond either - moving to next queue.
Comment #18
sunMoving over to next project.
Comment #19
sunTrying different approach now - maybe someone from the infrastructure team can change the package name for all projects and branches in one fell swoop?
Comment #20
apaderno@ #14
The list provided should be filtered out by checking which modules appears under
/project
; the last three listed are modules I once created, but I deleted them because they weren't of any use.Comment #21
apadernoif this approach doesn't work, would not it better to open an issue for any project having the wrong package name?
In this way, the issue would stay open until it has been resolved. Many people are not responding to this issue simply because they are busy doing something else (or they are in vacation); if the same issue is passed from project to project, it would not be seen from the maintainers, once it passed to the next project.
Comment #22
aaron CreditAttribution: aaron commentedi have several modules in that list. got them taken care of in the dev versions, but am not making new official releases at this time.
thanks for the attention to this issue.
Comment #23
sunThat depends a bit on the amount of remaining projects... @mfb: Can you compile an updated list?
Comment #24
apadernoI am marking this report as
.Comment #25
sunActually, it's fixed for most projects. :) There may be some modules left using the old name, but I'm sure that jQuery, jQuery UI, Wysiwyg, and others will broadcast the new standard.