Here's one to fix the duplicate package names caused by jQuery Update and Extlink, both of which are in the

package = User Interface

But extlink.module calls itself "User interface", thereby creating a second identical fieldset on the admin/build/modules page. I also added a newline at the end of the file, so the CVS packaging script would have some visual breathing space.

CommentFileSizeAuthor
extlink_package_capitalization.patch551 bytesSenpai
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Senpai’s picture

Status: Active » Needs review
sun’s picture

Status: Needs review » Reviewed & tested by the community

+1

quicksketch’s picture

Yeah sorry I'm delaying on this patch, it is totally minor, but really those *other modules* are using the wrong package name. Like other strings in Drupal (menu titles, form labels), package names should only include the first letter capitalized. So "User Interface" is incorrect, it should be "User interface". Should we take this to other modules or just say hose-it and go against convention?

sun’s picture

Well, UI is the abbreviation for User Interface - in this case, I thought the term was a proper noun and it would make sense to capitalize the second word, too, and changed it in jQuery Update 2.x accordingly.

apaderno’s picture

Acronyms may be written in upper case letter, but the words which create such acronyms are written in capital case only if it refers to some association, agency, or similar.
It's correct to write UI, but we should write user interface; it's correct to write USA, as it's correct to write United States of America.

In short, following also the conventions used in Drupal, the name of the module package should be written "User interface". Said that, there is also to report that there are more modules that use "User Interface" than "User interface".

apaderno’s picture

in this case, I thought the term was a proper noun

I would not insert user interface between the proper nouns; the right definition for proper noun is:

a name used for an individual person, place, or organization, spelled with initial capital letters, e.g., Larry, Mexico, and Boston Red Sox. Often contrasted with common noun.

The week day names are also written with the initial capital letters, and so the months names.

sun’s picture

Title: This patch fixes a Package naming & capitalization bug » Properly capitalize "User interface" package name
Assigned: Senpai » Unassigned
Category: bug » task
Priority: Minor » Normal

Ok. So let's start a joined effort by moving this task into all project issue queues; moving to the next, each time the package name has been fixed in the current project.

Proposing to move for two reasons: First of all, we can all push this very same issue, and secondly, other maintainers can read back then. I know that there are already existing issues in other queues suggesting the very same change - however, all maintainers will stop thinking about this, if we move the issue around.

I have commit access to

jQuery Update
jQuery UI
jQuery Lightbox
Wysiwyg API

(maybe more that might be affected, but I'm not aware of now) and committed this change using the following commit message and changelog entry now:

#227687 by sun: Fixed improperly capitalized package name.

@maintainers: Please do not change the issue status, this issue will be moved to the next project, so just report back that you're done.

quicksketch’s picture

Thanks sun!

sun’s picture

heh... was that a confirmation that you changed the package name in all branches of extlink?

sun’s picture

Project: External Links » jQuery Impromptu

meh, stupid me - External Links already uses the proper package name.

Moving over to next project.

@maintainer: Any other module under your hood may need to be updated, too. Please report back which projects/branches have been fixed.

sun’s picture

bump

sun’s picture

Project: jQuery Impromptu » jQuery plugins
Version: 5.x-1.x-dev » 6.x-1.4
Component: Code » User interface

It seems like Mike Smullin is unavailable currently. Moving to next queue.

(btw: using http://drupal.org/project/issues?text=%22User%20interface%22&states=1,16... as reference, which claims that jQuery Impromptu and jQuery plugins are the last two modules -- bonus points for finding other candidates! 8)

mfb’s picture

Thanks, fixed in jquery_plugin 5.x and 6.x branches.

mfb’s picture

Here's a list of affected modules in CVS HEAD:

activeedit/activeedit_theme_assist/activeedit_theme_assist.info:package = User Interface
activeedit/activeedit.info:package = User Interface
activemenu/activemenu.info:package = User Interface
block_refresh/block_refresh.info:package = User Interface
collapsiblock/collapsiblock.info:package = User Interface
editarea/editarea.info:package = User Interface
flir/flir.info:package = User Interface
hoverintent/hoverintent.info:package = User Interface
interface_sortable/interface_sortable_demos.info:package = User Interface
interface_sortable/interface_sortable.info:package = User Interface
jcarousel/jcarousel.info:package = User Interface
jcarousellite/jcarousellite.info:package = User Interface
jmedia/jmedia.info:package = User Interface
jq/contributions/jq_bridge/jq_bridge.info:package = User Interface
jq/jq.info:package = User Interface
jqmodal/jqmodal.info:package = User Interface
jquery_blockui/jquery_blockui.info:package = User Interface
jquery_calendar/jquery_calendar.info:package = "User Interface"
jquery_cookie/jquery_cookie.info:package = "User Interface"
jquery_fontsizer/jquery_fontsizer.info:package = "User Interface"
jquery_form/jquery_form.info:package = User Interface
jquery_heartbeat/jquery_heartbeat.info:package = "User Interface"
jquery_impromptu/jquery_impromptu.info:package = User Interface
jquery_media/jquery_media.info:package = User Interface
jquery_popupwindow/jquery_popupwindow.info:package = User Interface
jquery_treeview/jquery_treeview.info:package = "User Interface"
jquib/jquib.info:package = User Interface
jstools/jstools.info:package = User Interface
magnifier/magnifier.info:package = User Interface
nodecarousel/nodecarousel.info:package = User Interface
path_en/path_en.info:package = User Interface
quick_admin_menu/qam.info:package = User Interface
saveguard/saveguard.info:package = User Interface
swfaddress/swfaddress.info:package = "User Interface"
sys_en/sys_en.info:package = User Interface
tabs/docs/tabsexample.info:package = User Interface
tabs/tabs.info:package = User Interface
them_en/them_en.info:package = User Interface
user_en/user_en.info:package = User Interface
useren/useren.info:package = User Interface

sun’s picture

Project: jQuery plugins » Active edit
Version: 6.x-1.4 » 6.x-1.x-dev

ah well... LOL
So let's iterate over this list ;)

sun’s picture

Project: Active edit » Block Refresh
Version: 6.x-1.x-dev » 5.x-1.x-dev

@nedjo: Please come back to this issue when time permits; you seem to have commit access to some of the modules mentioned in #14.

Moving over to next project.

sun’s picture

Project: Block Refresh » Editarea

I just found out that I have CVS access to JavaScript tools - so I fixed this one. ;)

Aaron does not respond either - moving to next queue.

sun’s picture

Project: Editarea » Facelift Image Replacement Integration
Version: 5.x-1.x-dev » 6.x-1.0

Moving over to next project.

sun’s picture

Project: Facelift Image Replacement Integration » Drupal.org infrastructure
Version: 6.x-1.0 »
Component: User interface » CVS

Trying different approach now - maybe someone from the infrastructure team can change the package name for all projects and branches in one fell swoop?

apaderno’s picture

@ #14
The list provided should be filtered out by checking which modules appears under /project; the last three listed are modules I once created, but I deleted them because they weren't of any use.

apaderno’s picture

if this approach doesn't work, would not it better to open an issue for any project having the wrong package name?
In this way, the issue would stay open until it has been resolved. Many people are not responding to this issue simply because they are busy doing something else (or they are in vacation); if the same issue is passed from project to project, it would not be seen from the maintainers, once it passed to the next project.

aaron’s picture

i have several modules in that list. got them taken care of in the dev versions, but am not making new official releases at this time.

thanks for the attention to this issue.

sun’s picture

That depends a bit on the amount of remaining projects... @mfb: Can you compile an updated list?

apaderno’s picture

Status: Reviewed & tested by the community » Closed (won't fix)

I am marking this report as won't fix.

sun’s picture

Status: Closed (won't fix) » Fixed

Actually, it's fixed for most projects. :) There may be some modules left using the old name, but I'm sure that jQuery, jQuery UI, Wysiwyg, and others will broadcast the new standard.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Component: CVS » Other