Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The site logo now uses the site name as an alternative text which is not correct, it should contain the Governments sender.
Comment | File | Size | Author |
---|---|---|---|
#6 | use_the_correct_alt-2487882-6.patch | 685 bytes | Oostie |
#4 | use_the_correct_alt-2487882-4.patch | 698 bytes | Oostie |
#1 | use_the_correct_alt-2487882-1.patch | 705 bytes | Oostie |
Comments
Comment #1
OostieComment #2
OostieComment #3
BarisW CreditAttribution: BarisW at LimoenGroen commentedGood catch. But what's the use of the nl2br call? I don't think we need that one in an alt tag?
Comment #4
OostieYour right! i removed the nl2br function.
Comment #5
BarisW CreditAttribution: BarisW at LimoenGroen commentedGreat, thanks. One last thing: the use of check_plain is unwanted here. Because you already use a '@' placeholder, the content is check_plained already.
Having the check_plain here can cause double encoding. So if $sender is just text, the check_plain can be removed. If $sender can contain HTML, we might want to use strip_tags instead.
Comment #6
OostieFixed, thnx!
Comment #7
BarisW CreditAttribution: BarisW at LimoenGroen commented+1
Comment #8
BarisW CreditAttribution: BarisW at LimoenGroen commentedTo be committed today.
Comment #10
BarisW CreditAttribution: BarisW at LimoenGroen commentedCommited, thanks!