The site logo now uses the site name as an alternative text which is not correct, it should contain the Governments sender.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Oostie’s picture

Oostie’s picture

Issue summary: View changes
BarisW’s picture

Good catch. But what's the use of the nl2br call? I don't think we need that one in an alt tag?

Oostie’s picture

Your right! i removed the nl2br function.

BarisW’s picture

Great, thanks. One last thing: the use of check_plain is unwanted here. Because you already use a '@' placeholder, the content is check_plained already.
Having the check_plain here can cause double encoding. So if $sender is just text, the check_plain can be removed. If $sender can contain HTML, we might want to use strip_tags instead.

Oostie’s picture

Fixed, thnx!

BarisW’s picture

Status: Active » Reviewed & tested by the community

+1

BarisW’s picture

Issue tags: +rijkshuisstijlsprint

To be committed today.

  • BarisW committed c103846 on 7.x-3.x authored by Oostie
    Issue #2487882 by Oostie, BarisW: Use the correct alt text on the site...
BarisW’s picture

Status: Reviewed & tested by the community » Fixed

Commited, thanks!

  • Martijn de Wit committed e4766e3 on 7.x-3.x
    Merge branch '7.x-3.x' of git.drupal.org:project/rijkshuisstijl into 7.x...

  • BarisW committed 0468f8d on 7.x-3.x authored by Oostie
    Issue #2487882 by Oostie, BarisW: Use the correct alt text on the site...
  • Martijn de Wit committed 51ab3e9 on 7.x-3.x
    Merge branch '7.x-3.x' of git.drupal.org:project/rijkshuisstijl into 7.x...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.