"Images must be smaller than @max_size pixels"

should say:

"Images larger than @max_size pixels will be scaled"

--------------------

"Must be an JPEG, PNG or GIF image"

should say:

"Must be a JPEG, PNG or GIF image"

-------------

and "bigger" -> "larger" for consistency. (and it's a nicer word :) )

CommentFileSizeAuthor
#5 filefield-strings-exact-size.patch819 bytesMoonshine
#3 filefield-strings-v2.patch1.1 KBMoonshine
filefield-strings.patch959 bytesMoonshine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Needs work

they're only scaled if core has an enabled image toolkit... the other bits look good though.

Moonshine’s picture

Moonshine CreditAttribution: Moonshine commented

Ahhhh.. I'll make that one conditional then, just need to look at the code a bit.

Moonshine’s picture

Moonshine CreditAttribution: Moonshine commented
Status: Needs work » Needs review
FileSize
filefield-strings-v2.patch1.1 KB

Updated version..

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Fixed

thanks, committed to HEAD.

Moonshine’s picture

Moonshine CreditAttribution: Moonshine commented
Status: Fixed » Active
FileSize
filefield-strings-exact-size.patch819 bytes

Sorry I missed this one, but I think it's worth adding... Nice for "exact" size requirements like ads.

Moonshine’s picture

Moonshine CreditAttribution: Moonshine commented
Status: Active » Needs review

oops wrong status.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Fixed

thanks, committed to HEAD.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.