diff --git a/core/includes/menu.inc b/core/includes/menu.inc index d28316b..fb9b378 100644 --- a/core/includes/menu.inc +++ b/core/includes/menu.inc @@ -2669,8 +2669,7 @@ function menu_router_rebuild() { $transaction = db_transaction(); try { - list($menu, $masks) = menu_router_build(); - _menu_router_save($menu, $masks); + list($menu, $masks) = menu_router_build(TRUE); _menu_navigation_links_rebuild($menu); // Clear the menu, page and block caches. menu_cache_clear_all(); @@ -2689,8 +2688,11 @@ function menu_router_rebuild() { /** * Collects and alters the menu definitions. + * + * @param bool $save + * (Optional) Save the new router to the database. Defaults to FALSE. */ -function menu_router_build() { +function menu_router_build($save = FALSE) { // We need to manually call each module so that we can know which module // a given item came from. $callbacks = array(); @@ -2705,7 +2707,7 @@ function menu_router_build() { } // Alter the menu as defined in modules, keys are like user/%user. drupal_alter('menu', $callbacks); - list($menu, $masks) = _menu_router_build($callbacks); + list($menu, $masks) = _menu_router_build($callbacks, $save); _menu_router_cache($menu); return array($menu, $masks); @@ -3488,11 +3490,12 @@ function _menu_link_parents_set(&$item, $parent) { /** * Builds the router table based on the data from hook_menu(). */ -function _menu_router_build($callbacks) { +function _menu_router_build($callbacks, $save = FALSE) { // First pass: separate callbacks from paths, making paths ready for // matching. Calculate fitness, and fill some default values. $menu = array(); $masks = array(); + $path_roots = array(); foreach ($callbacks as $path => $item) { $load_functions = array(); $to_arg_functions = array(); @@ -3500,6 +3503,7 @@ function _menu_router_build($callbacks) { $move = FALSE; $parts = explode('/', $path, MENU_MAX_PARTS); + $path_roots[$parts[0]] = $parts[0]; $number_parts = count($parts); // We store the highest index of parts here to save some work in the fit // calculation loop. @@ -3706,6 +3710,18 @@ function _menu_router_build($callbacks) { $masks = array_keys($masks); rsort($masks); + if ($save) { + $path_roots = array_values($path_roots); + // Update the path roots variable and reset the path alias whitelist cache + // if the list has changed. + + if ($path_roots != state()->get('menu_path_roots')) { + state()->set('menu_path_roots', array_values($path_roots)); + cache()->delete('path_alias_whitelist'); + } + _menu_router_save($menu, $masks); + } + return array($menu, $masks); } diff --git a/core/includes/path.inc b/core/includes/path.inc index dc878c0..20761b0 100644 --- a/core/includes/path.inc +++ b/core/includes/path.inc @@ -9,6 +9,8 @@ * executing "drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);". */ +use Drupal\Core\Utility\PathAliasWhitelist; + /** * Initializes the current path to the proper normal path. */ @@ -63,21 +65,13 @@ function drupal_lookup_path($action, $path = '', $langcode = NULL) { $cache = array( 'map' => array(), 'no_source' => array(), - 'whitelist' => NULL, + 'whitelist' => new PathAliasWhitelist('path_alias_whitelist', 'cache'), 'system_paths' => array(), 'no_aliases' => array(), 'first_call' => TRUE, ); } - // Retrieve the path alias whitelist. - if (!isset($cache['whitelist'])) { - $cache['whitelist'] = state()->get('system.path_alias_whitelist', NULL); - if (!isset($cache['whitelist'])) { - $cache['whitelist'] = drupal_path_alias_whitelist_rebuild(); - } - } - // If no language is explicitly specified we default to the current URL // language. If we used a language different from the one conveyed by the // requested URL, we might end up being unable to check if there is a path @@ -86,9 +80,9 @@ function drupal_lookup_path($action, $path = '', $langcode = NULL) { if ($action == 'wipe') { $cache = array(); - $cache['whitelist'] = drupal_path_alias_whitelist_rebuild(); + drupal_path_alias_whitelist_rebuild(); } - elseif ($cache['whitelist'] && $path != '') { + elseif ($path != '') { if ($action == 'alias') { // During the first call to drupal_lookup_path() per language, load the // expected system paths for the page from cache. @@ -383,29 +377,21 @@ function current_path() { * * @param $source * An optional system path for which an alias is being inserted. - * - * @return - * An array containing a white list of path aliases. */ function drupal_path_alias_whitelist_rebuild($source = NULL) { // When paths are inserted, only rebuild the whitelist if the system path // has a top level component which is not already in the whitelist. + $static = &drupal_static('drupal_lookup_path'); if (!empty($source)) { - $whitelist = state()->get('system.path_alias_whitelist', NULL); - if (isset($whitelist[strtok($source, '/')])) { - return $whitelist; + if (isset($static['whitelist'][strtok($source, '/')])) { + return; } } - // For each alias in the database, get the top level component of the system - // path it corresponds to. This is the portion of the path before the first - // '/', if present, otherwise the whole path itself. - $whitelist = array(); - $result = db_query("SELECT DISTINCT SUBSTRING_INDEX(source, '/', 1) AS path FROM {url_alias}"); - foreach ($result as $row) { - $whitelist[$row->path] = TRUE; + // There might be an uninitialized case. + if (!isset($static['whitelist'])) { + $static['whitelist'] = new PathAliasWhitelist('path_alias_whitelist', 'cache'); } - state()->set('system.path_alias_whitelist', $whitelist); - return $whitelist; + $static['whitelist']->clear(); } /** diff --git a/core/lib/Drupal/Core/Utility/CacheArray.php b/core/lib/Drupal/Core/Utility/CacheArray.php index 33d955c..8ec6941 100644 --- a/core/lib/Drupal/Core/Utility/CacheArray.php +++ b/core/lib/Drupal/Core/Utility/CacheArray.php @@ -212,6 +212,15 @@ protected function set($data, $lock = TRUE) { } /** + * Clear the cache. + */ + public function clear() { + $this->storage = array(); + $this->keysToPersist = array(); + cache($this->bin)->delete($this->cid); + } + + /** * Destructs the DrupalCacheArray object. */ public function __destruct() { diff --git a/core/lib/Drupal/Core/Utility/PathAliasWhitelist.php b/core/lib/Drupal/Core/Utility/PathAliasWhitelist.php new file mode 100644 index 0000000..10a19a7 --- /dev/null +++ b/core/lib/Drupal/Core/Utility/PathAliasWhitelist.php @@ -0,0 +1,107 @@ +storage will be empty and the whitelist will + // need to be rebuilt from scratch. The whitelist is initialized from the + // list of all valid path roots stored in the 'menu_path_roots' state, + // with values initialized to NULL. During the request, each path requested + // that matches one of these keys will be looked up and the array value set + // to either TRUE or FALSE. This ensures that paths which do not exist in + // the router are not looked up, and that paths that do exist in the router + // are only looked up once. + if (empty($this->storage)) { + $this->LoadMenuPathRoots(); + } + } + + /** + * Load menu path roots to prepopulate cache. + */ + protected function loadMenuPathRoots() { + if ($roots = state()->get('menu_path_roots')) { + foreach ($roots as $root) { + $this->storage[$root] = NULL; + $this->persist($root); + } + } + } + + /** + * Overrides ArrayAccess::offsetGet(). + */ + public function offsetGet($offset) { + // url() may be called with paths that are not represented by menu router + // items such as paths that will be rewritten by hook_url_outbound_alter(). + // Therefore internally TRUE is used to indicate whitelisted paths. FALSE is + // used to indicate paths that have already been checked but are not + // whitelisted, and NULL indicates paths that have not been checked yet. + if (isset($this->storage[$offset])) { + if ($this->storage[$offset]) { + return TRUE; + } + } + elseif (array_key_exists($offset, $this->storage)) { + return $this->resolveCacheMiss($offset); + } + } + + /** + * Overrides CacheArray::resolveCacheMiss(). + */ + public function resolveCacheMiss($root) { + $query = db_select('url_alias', 'u'); + $query->addExpression(1); + $query->condition('u.source', db_like($root) . '%', 'LIKE') ->range(0, 1); + $exists = (bool) $query->execute()->fetchField(); + $this->storage[$root] = $exists; + $this->persist($root); + if ($exists) { + return TRUE; + } + } + + /** + * Overrides CacheArray::set(). + */ + public function set($data, $lock = TRUE) { + $lock_name = $this->cid . ':' . $this->bin; + if (!$lock || lock()->acquire($lock_name)) { + if ($cached = cache($this->bin)->get($this->cid)) { + // Use array merge instead of union so that filled in values in $data + // overwrite empty values in the current cache. + $data = array_merge($cached->data, $data); + } + cache($this->bin)->set($this->cid, $data); + if ($lock) { + lock()->release($lock_name); + } + } + } + + /** + * Overrides CacheArray::clear(). + */ + public function clear() { + parent::clear(); + $this->loadMenuPathRoots(); + } +} diff --git a/core/modules/forum/lib/Drupal/forum/Tests/ForumNodeAccessTest.php b/core/modules/forum/lib/Drupal/forum/Tests/ForumNodeAccessTest.php index 5ad396a..f9ee1e3 100644 --- a/core/modules/forum/lib/Drupal/forum/Tests/ForumNodeAccessTest.php +++ b/core/modules/forum/lib/Drupal/forum/Tests/ForumNodeAccessTest.php @@ -91,7 +91,7 @@ function testForumNodeAccess() { // Test for $access_user. $this->drupalLogin($access_user); - $this->drupalGet('/'); + $this->drupalGet(''); // Ensure private node and public node are found. $this->assertText($private_node->title, 'Private node found in block by $access_user'); @@ -99,7 +99,7 @@ function testForumNodeAccess() { // Test for $no_access_user. $this->drupalLogin($no_access_user); - $this->drupalGet('/'); + $this->drupalGet(''); // Ensure private node is not found but public is found. $this->assertNoText($private_node->title, 'Private node not found in block by $no_access_user'); diff --git a/core/modules/path/lib/Drupal/path/Tests/PathAliasTest.php b/core/modules/path/lib/Drupal/path/Tests/PathAliasTest.php index 181bd72..794b807 100644 --- a/core/modules/path/lib/Drupal/path/Tests/PathAliasTest.php +++ b/core/modules/path/lib/Drupal/path/Tests/PathAliasTest.php @@ -51,7 +51,8 @@ function testPathCache() { // Visit the system path for the node and confirm a cache entry is // created. cache('path')->flush(); - $this->drupalGet($edit['source']); + // Make sure the path is not converted to the alias. + $this->drupalGet($edit['source'], array('alias' => TRUE)); $this->assertTrue(cache('path')->get($edit['source']), 'Cache entry was created.'); // Visit the alias for the node and confirm a cache entry is created. diff --git a/core/modules/path/lib/Drupal/path/Tests/PathLanguageTest.php b/core/modules/path/lib/Drupal/path/Tests/PathLanguageTest.php index e6fd10d..55f47af 100644 --- a/core/modules/path/lib/Drupal/path/Tests/PathLanguageTest.php +++ b/core/modules/path/lib/Drupal/path/Tests/PathLanguageTest.php @@ -97,6 +97,7 @@ function testAliasTranslation() { drupal_static_reset('language_list'); drupal_static_reset('language_url_outbound_alter'); drupal_static_reset('language_url_rewrite_url'); + drupal_static_reset('drupal_lookup_path'); $languages = language_list(); $url = url('node/' . $french_node->nid, array('language' => $languages[$french_node->langcode])); $this->assertTrue(strpos($url, $edit['path[alias]']), 'URL contains the path alias.');