diff --git a/core/modules/comment/comment.module b/core/modules/comment/comment.module index 70218a5..4acbe6d 100644 --- a/core/modules/comment/comment.module +++ b/core/modules/comment/comment.module @@ -1841,7 +1841,7 @@ function comment_form($form, &$form_state, $comment) { // If a content type has multilingual support we set the comment to inherit the // content language. Otherwise mark the comment as language neutral. $comment_langcode = $comment->language; - if (($comment_langcode == LANGUAGE_NONE) && variable_get('language_content_type_' . $node->type, 0)) { + if (($comment_langcode == LANGUAGE_NONE) && variable_get('node_type_language_' . $node->type, 0)) { $comment_langcode = $language_content->langcode; } $form['language'] = array( diff --git a/core/modules/field/modules/text/text.test b/core/modules/field/modules/text/text.test index 5936937..e061a39 100644 --- a/core/modules/field/modules/text/text.test +++ b/core/modules/field/modules/text/text.test @@ -434,7 +434,7 @@ class TextTranslationTestCase extends DrupalWebTestCase { $this->drupalPost('admin/config/regional/language/add', $edit, t('Add language')); // Set "Article" content type to use multilingual support with translation. - $edit = array('language_content_type' => 2); + $edit = array('node_type_language' => 2); $this->drupalPost('admin/structure/types/manage/article', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Article')), t('Article content type has been updated.')); } diff --git a/core/modules/locale/locale.module b/core/modules/locale/locale.module index 10feebb..1c520cc 100644 --- a/core/modules/locale/locale.module +++ b/core/modules/locale/locale.module @@ -247,31 +247,6 @@ function locale_language_selector_form($user) { } /** - * Implements hook_form_FORM_ID_alter(). - */ -function locale_form_node_type_form_alter(&$form, &$form_state) { - if (isset($form['type'])) { - $form['workflow']['language_content_type'] = array( - '#type' => 'radios', - '#title' => t('Multilingual support'), - '#default_value' => variable_get('language_content_type_' . $form['#node_type']->type, 0), - '#options' => array(t('Disabled'), t('Enabled')), - '#description' => t('Enable multilingual support for this content type. If enabled, a language selection field will be added to the editing form, allowing you to select from one of the enabled languages. If disabled, new posts are saved with the default language. Existing content will not be affected by changing this option.', array('!languages' => url('admin/config/regional/language'))), - ); - } -} - -/** - * Return whether the given content type has multilingual support. - * - * @return - * True if multilingual support is enabled. - */ -function locale_multilingual_node_type($type_name) { - return (bool) variable_get('language_content_type_' . $type_name, 0); -} - -/** * Implements hook_form_alter(). * * Adds language fields to user forms. @@ -295,28 +270,6 @@ function locale_form_alter(&$form, &$form_state, $form_id) { * Implements hook_form_BASE_FORM_ID_alter(). */ function locale_form_node_form_alter(&$form, &$form_state) { - if (isset($form['#node']->type) && locale_multilingual_node_type($form['#node']->type)) { - $languages = language_list(TRUE); - foreach ($languages as $langcode => $language) { - $language_options[$langcode] = $language->name; - } - $form['language'] = array( - '#type' => 'select', - '#title' => t('Language'), - '#default_value' => (isset($form['#node']->language) ? $form['#node']->language : ''), - '#options' => $language_options, - '#empty_value' => LANGUAGE_NONE, - '#empty_option' => t('- None -'), - ); - } - // Node type without language selector: assign the default for new nodes - elseif (!isset($form['#node']->nid)) { - $default = language_default(); - $form['language'] = array( - '#type' => 'value', - '#value' => $default->langcode - ); - } $form['#submit'][] = 'locale_field_node_form_submit'; } diff --git a/core/modules/locale/locale.test b/core/modules/locale/locale.test index 5408ccd..8d06db4 100644 --- a/core/modules/locale/locale.test +++ b/core/modules/locale/locale.test @@ -1104,7 +1104,7 @@ class LocaleUninstallFunctionalTest extends DrupalWebTestCase { $this->assertEqual($GLOBALS['language']->langcode, $this->langcode, t('Current language: %lang', array('%lang' => $GLOBALS['language']->langcode))); // Enable multilingual workflow option for articles. - variable_set('language_content_type_article', 1); + variable_set('node_type_language_article', 1); // Change JavaScript translations directory. variable_set('locale_js_directory', 'js_translations'); @@ -1173,10 +1173,6 @@ class LocaleUninstallFunctionalTest extends DrupalWebTestCase { $javascript_parsed_count = count(variable_get('javascript_parsed', array())); $this->assertEqual($javascript_parsed_count, 0, t('JavaScript parsed count: %count', array('%count' => $javascript_parsed_count))); - // Check multilingual workflow option for articles. - $multilingual = variable_get('language_content_type_article', 0); - $this->assertEqual($multilingual, 0, t('Multilingual workflow option: %status', array('%status' => t($multilingual ? 'enabled': 'disabled')))); - // Check JavaScript translations directory. $locale_js_directory = variable_get('locale_js_directory', 'languages'); $this->assertEqual($locale_js_directory, 'languages', t('JavaScript translations directory: %dir', array('%dir' => $locale_js_directory))); @@ -1823,7 +1819,7 @@ class LocaleContentFunctionalTest extends DrupalWebTestCase { $this->drupalGet('admin/structure/types/manage/page'); $this->assertText(t('Multilingual support'), t('Multilingual support fieldset present on content type configuration form.')); $edit = array( - 'language_content_type' => 1, + 'node_type_language' => 1, ); $this->drupalPost('admin/structure/types/manage/page', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Basic page')), t('Basic page content type has been updated.')); @@ -1893,7 +1889,7 @@ class LocaleContentFunctionalTest extends DrupalWebTestCase { // Set "Article" content type to use multilingual support. $this->drupalGet('admin/structure/types/manage/article'); $edit = array( - 'language_content_type' => 1, + 'node_type_language' => 1, ); $this->drupalPost('admin/structure/types/manage/article', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Article')), t('Article content type has been updated.')); @@ -2385,7 +2381,7 @@ class LocaleMultilingualFieldsFunctionalTest extends DrupalWebTestCase { // Set "Basic page" content type to use multilingual support. $edit = array( - 'language_content_type' => 1, + 'node_type_language' => 1, ); $this->drupalPost('admin/structure/types/manage/page', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Basic page')), t('Basic page content type has been updated.')); @@ -2499,7 +2495,7 @@ class LocaleCommentLanguageFunctionalTest extends DrupalWebTestCase { $this->drupalPost('admin/config/regional/language/add', $edit, t('Add language')); // Set "Article" content type to use multilingual support. - $edit = array('language_content_type' => 1); + $edit = array('node_type_language' => 1); $this->drupalPost('admin/structure/types/manage/article', $edit, t('Save content type')); // Enable content language negotiation UI. diff --git a/core/modules/node/content_types.inc b/core/modules/node/content_types.inc index c76a5e2..e2440d3 100644 --- a/core/modules/node/content_types.inc +++ b/core/modules/node/content_types.inc @@ -187,6 +187,14 @@ function node_type_form($form, &$form_state, $type = NULL) { ), '#description' => t('Users with the Administer content permission will be able to override these options.'), ); + if (module_exists('language')) { + $form['workflow']['node_type_language'] = array( + '#type' => 'checkbox', + '#title' => t('Multilingual support'), + '#default_value' => variable_get('node_type_language_' . $type->type, 0), + '#description' => t('Add a language selection field to the editing form, allowing you to select from one of the enabled languages. If disabled, new posts are saved with the default language. Existing content will not be affected by changing this option.', array('!languages' => url('admin/config/regional/language'))), + ); + } $form['display'] = array( '#type' => 'fieldset', '#title' => t('Display settings'), diff --git a/core/modules/node/node.install b/core/modules/node/node.install index 82fd2e7..8c80ad2 100644 --- a/core/modules/node/node.install +++ b/core/modules/node/node.install @@ -456,6 +456,7 @@ function node_uninstall() { ->condition('name', 'node_options_' . $type) ->condition('name', 'node_submitted_' . $type) ->condition('name', 'node_permissions_' . $type) + ->condition('name', 'node_type_language_' . $type) ) ->execute(); } @@ -525,6 +526,22 @@ function node_update_8000() { } /** + * Convert existing node type language settings to its new name. + * + * @see http://drupal.org/node/540294 + */ +function node_update_8001() { + $types = db_query('SELECT type FROM {node_type}')->fetchCol(); + foreach ($types as $type) { + $language = variable_get('language_content_type_' . $type); + if (isset($language)) { + variable_set('node_type_language_' . $type, $language); + } + variable_del('language_content_type_' . $type); + } +} + +/** * @} End of "addtogroup updates-7.x-to-8.x" * The next series of updates should start at 9000. */ diff --git a/core/modules/node/node.pages.inc b/core/modules/node/node.pages.inc index cd1eb6d..4c1934c 100644 --- a/core/modules/node/node.pages.inc +++ b/core/modules/node/node.pages.inc @@ -181,6 +181,30 @@ function node_form($form, &$form_state, $node) { // @todo D8: Remove. Modules should access the node using $form_state['node']. $form['#node'] = $node; + if (variable_get('node_type_language_' . $node->type, 0) && module_exists('language')) { + $languages = language_list(TRUE); + $language_options = array(); + foreach ($languages as $langcode => $language) { + $language_options[$langcode] = $language->name; + } + $form['language'] = array( + '#type' => 'select', + '#title' => t('Language'), + '#default_value' => (isset($node->language) ? $node->language : ''), + '#options' => $language_options, + '#empty_value' => LANGUAGE_NONE, + '#empty_option' => t('- None -'), + ); + } + else { + $form['language'] = array( + '#type' => 'value', + // New nodes without multilingual support get the default language, old + // nodes keep their language if language.module is not available. + '#value' => !isset($form['#node']->nid) ? language_default()->langcode : $node->language, + ); + } + $form['additional_settings'] = array( '#type' => 'vertical_tabs', '#weight' => 99, diff --git a/core/modules/path/path.test b/core/modules/path/path.test index d5a18d3..f8fb8cf 100644 --- a/core/modules/path/path.test +++ b/core/modules/path/path.test @@ -260,7 +260,7 @@ class PathLanguageTestCase extends DrupalWebTestCase { */ function testAliasTranslation() { // Set 'page' content type to enable translation. - variable_set('language_content_type_page', 2); + variable_set('node_type_language_page', 2); $english_node = $this->drupalCreateNode(array('type' => 'page')); $english_alias = $this->randomName(); diff --git a/core/modules/poll/poll.test b/core/modules/poll/poll.test index ea8b341..2d3acc3 100644 --- a/core/modules/poll/poll.test +++ b/core/modules/poll/poll.test @@ -843,7 +843,7 @@ class PollTranslateTestCase extends PollTestCase { // Set "Poll" content type to use multilingual support with translation. $this->drupalGet('admin/structure/types/manage/poll'); $edit = array(); - $edit['language_content_type'] = 2; + $edit['node_type_language'] = 2; $this->drupalPost('admin/structure/types/manage/poll', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Poll')), t('Poll content type has been updated.')); diff --git a/core/modules/simpletest/tests/upgrade/drupal-7.language.database.php b/core/modules/simpletest/tests/upgrade/drupal-7.language.database.php index 02ae24e..255aa20 100644 --- a/core/modules/simpletest/tests/upgrade/drupal-7.language.database.php +++ b/core/modules/simpletest/tests/upgrade/drupal-7.language.database.php @@ -52,6 +52,37 @@ db_insert('block')->fields(array( )) ->execute(); +// Locale content type has comment_body and body +db_insert('field_config_instance')->fields(array( + 'id', + 'field_id', + 'field_name', + 'entity_type', + 'bundle', + 'data', + 'deleted', +)) +->values(array( + 'id' => '43', + 'field_id' => '1', + 'field_name' => 'comment_body', + 'entity_type' => 'comment', + 'bundle' => 'comment_node_locale', + 'data' => 'a:6:{s:5:"label";s:7:"Comment";s:8:"settings";a:2:{s:15:"text_processing";i:1;s:18:"user_register_form";b:0;}s:8:"required";b:1;s:7:"display";a:1:{s:7:"default";a:5:{s:5:"label";s:6:"hidden";s:4:"type";s:12:"text_default";s:6:"weight";i:0;s:8:"settings";a:0:{}s:6:"module";s:4:"text";}}s:6:"widget";a:4:{s:4:"type";s:13:"text_textarea";s:8:"settings";a:1:{s:4:"rows";i:5;}s:6:"weight";i:0;s:6:"module";s:4:"text";}s:11:"description";s:0:"";}', + 'deleted' => '0', +)) +->values(array( + 'id' => '44', + 'field_id' => '2', + 'field_name' => 'body', + 'entity_type' => 'node', + 'bundle' => 'locale', + 'data' => 'a:6:{s:5:"label";s:4:"Body";s:6:"widget";a:4:{s:4:"type";s:26:"text_textarea_with_summary";s:8:"settings";a:2:{s:4:"rows";i:20;s:12:"summary_rows";i:5;}s:6:"weight";i:-4;s:6:"module";s:4:"text";}s:8:"settings";a:3:{s:15:"display_summary";b:1;s:15:"text_processing";i:1;s:18:"user_register_form";b:0;}s:7:"display";a:2:{s:7:"default";a:5:{s:5:"label";s:6:"hidden";s:4:"type";s:12:"text_default";s:8:"settings";a:0:{}s:6:"module";s:4:"text";s:6:"weight";i:0;}s:6:"teaser";a:5:{s:5:"label";s:6:"hidden";s:4:"type";s:23:"text_summary_or_trimmed";s:8:"settings";a:1:{s:11:"trim_length";i:600;}s:6:"module";s:4:"text";s:6:"weight";i:0;}}s:8:"required";b:0;s:11:"description";s:0:"";}', + 'deleted' => '0', +)) +->execute(); + + // Add language table from locale.install schema and prefill with some default // languages for testing. db_create_table('languages', array( @@ -473,16 +504,84 @@ db_create_table('locales_target', array( 'name' => 'locales_target', )); +db_insert('node_type')->fields(array( + 'type', + 'name', + 'base', + 'module', + 'description', + 'help', + 'has_title', + 'title_label', + 'custom', + 'modified', + 'locked', + 'disabled', + 'orig_type', +)) +->values(array( + 'type' => 'locale', + 'name' => 'Locale', + 'base' => 'node_content', + 'module' => 'node', + 'description' => "Content type with language support.\r\n\r\n@see core/modules/simpletest/tests/upgrade/drupal-7.language.database.php\r\n@see core/modules/simpletest/tests/upgrade/upgrade.language.test", + 'help' => '', + 'has_title' => '1', + 'title_label' => 'Title', + 'custom' => '1', + 'modified' => '1', + 'locked' => '0', + 'disabled' => '0', + 'orig_type' => 'locale', +)) +->execute(); + // Set up variables needed for language support. db_insert('variable')->fields(array( 'name', 'value', )) ->values(array( + 'name' => 'additional_settings__active_tab_locale', + 'value' => 's:13:"edit-workflow";', +)) +->values(array( + 'name' => 'comment_anonymous_locale', + 'value' => 'i:0;', +)) +->values(array( + 'name' => 'comment_default_mode_locale', + 'value' => 'i:1;', +)) +->values(array( + 'name' => 'comment_default_per_page_locale', + 'value' => 's:2:"50";', +)) +->values(array( + 'name' => 'comment_form_location_locale', + 'value' => 'i:1;', +)) +->values(array( + 'name' => 'comment_locale', + 'value' => 's:1:"2";', +)) +->values(array( + 'name' => 'comment_preview_locale', + 'value' => 's:1:"1";', +)) +->values(array( + 'name' => 'comment_subject_field_locale', + 'value' => 'i:1;', +)) +->values(array( 'name' => 'javascript_parsed', 'value' => 'a:16:{i:0;s:14:"misc/drupal.js";i:1;s:14:"misc/jquery.js";i:2;s:19:"misc/jquery.once.js";s:10:"refresh:ca";s:7:"waiting";i:3;s:29:"misc/ui/jquery.ui.core.min.js";i:4;s:21:"misc/jquery.ba-bbq.js";i:5;s:33:"modules/overlay/overlay-parent.js";i:6;s:32:"modules/contextual/contextual.js";i:7;s:21:"misc/jquery.cookie.js";i:8;s:26:"modules/toolbar/toolbar.js";i:9;s:32:"modules/overlay/overlay-child.js";i:10;s:19:"misc/tableheader.js";i:11;s:17:"misc/tabledrag.js";i:12;s:12:"misc/form.js";i:13;s:16:"misc/collapse.js";s:10:"refresh:cv";s:7:"waiting";}', )) ->values(array( + 'name' => 'language_content_type_locale', + 'value' => 's:1:"1";', +)) +->values(array( 'name' => 'language_count', 'value' => 'i:3;', )) @@ -510,6 +609,18 @@ db_insert('variable')->fields(array( 'name' => 'locale_language_providers_weight_language', 'value' => 'a:5:{s:10:"locale-url";s:2:"-8";s:14:"locale-session";s:2:"-6";s:11:"locale-user";s:2:"-4";s:14:"locale-browser";s:2:"-2";s:16:"language-default";s:2:"10";}', )) +->values(array( + 'name' => 'node_options_locale', + 'value' => 'a:2:{i:0;s:6:"status";i:1;s:7:"promote";}', +)) +->values(array( + 'name' => 'node_preview_locale', + 'value' => 's:1:"1";', +)) +->values(array( + 'name' => 'node_submitted_locale', + 'value' => 'i:1;', +)) ->execute(); // Enable the locale module. diff --git a/core/modules/translation/translation.module b/core/modules/translation/translation.module index da719aa..1fa8fbc 100644 --- a/core/modules/translation/translation.module +++ b/core/modules/translation/translation.module @@ -111,9 +111,10 @@ function translation_permission() { */ function translation_form_node_type_form_alter(&$form, &$form_state) { // Add translation option to content type form. - $form['workflow']['language_content_type']['#options'][TRANSLATION_ENABLED] = t('Enabled, with translation'); - // Description based on text from locale.module. - $form['workflow']['language_content_type']['#description'] = t('Enable multilingual support for this content type. If enabled, a language selection field will be added to the editing form, allowing you to select from one of the enabled languages. You can also turn on translation for this content type, which lets you have content translated to any of the installed languages. If disabled, new posts are saved with the default language. Existing content will not be affected by changing this option.', array('!languages' => url('admin/config/regional/language'))); + $form['workflow']['node_type_language']['#type'] = 'radios'; + $form['workflow']['node_type_language']['#options'] = array(t('Disabled'), t('Enabled'), TRANSLATION_ENABLED => t('Enabled, with translation')); + // Description based on text from node.module. + $form['workflow']['node_type_language']['#description'] = t('Add a language selection field to the editing form, allowing you to select from one of the enabled languages. You can also turn on translation for this content type, which lets you have content translated to any of the installed languages. If disabled, new posts are saved with the default language. Existing content will not be affected by changing this option.', array('!languages' => url('admin/config/regional/language'))); } /** @@ -475,7 +476,7 @@ function translation_node_get_translations($tnid) { * Boolean value. */ function translation_supported_type($type) { - return variable_get('language_content_type_' . $type, 0) == TRANSLATION_ENABLED; + return variable_get('node_type_language_' . $type, 0) == TRANSLATION_ENABLED; } /** diff --git a/core/modules/translation/translation.test b/core/modules/translation/translation.test index cebe9a5..eeee661 100644 --- a/core/modules/translation/translation.test +++ b/core/modules/translation/translation.test @@ -38,7 +38,7 @@ class TranslationTestCase extends DrupalWebTestCase { // translation. $this->drupalGet('admin/structure/types/manage/page'); $edit = array(); - $edit['language_content_type'] = 2; + $edit['node_type_language'] = 2; $this->drupalPost('admin/structure/types/manage/page', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', array('%type' => 'Basic page')), t('Basic page content type has been updated.')); @@ -231,7 +231,7 @@ class TranslationTestCase extends DrupalWebTestCase { // Disable translation support to check that the language switcher is left // untouched only for new nodes. $this->drupalLogin($this->admin_user); - $edit = array('language_content_type' => 0); + $edit = array('node_type_language' => 0); $this->drupalPost('admin/structure/types/manage/page', $edit, t('Save content type')); $this->drupalLogin($this->translator);